Skip to content

Change unversioned image aliases to corresponding URN #6889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReaNAiveD merged 10 commits into from
Dec 6, 2023
Merged

Change unversioned image aliases to corresponding URN #6889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4656a9f
change removed aliases in test to corresponding urn
ReaNAiveD Oct 16, 2023
d256ebe
Merge branch 'main' into drop-unversioned-aliases
ReaNAiveD Oct 16, 2023
98bce60
Merge branch 'main' into drop-unversioned-aliases
ReaNAiveD Oct 20, 2023
f4234a1
Merge branch 'main' into drop-unversioned-aliases
ReaNAiveD Oct 23, 2023
a167357
Merge branch 'main' into drop-unversioned-aliases
ReaNAiveD Oct 26, 2023
f6bd012
Merge branch 'main' into drop-unversioned-aliases
ReaNAiveD Nov 6, 2023
6ae2b60
revert updates in `scheduled-query`
ReaNAiveD Nov 6, 2023
353d4a3
revert updates in `automanage`, `connection-monitor-preview`
ReaNAiveD Nov 6, 2023
05ac3f1
revert updates in `image-gallery`
ReaNAiveD Nov 6, 2023
e41bee1
revert updates in `aem`
ReaNAiveD Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/automation/azext_automation/tests/latest/test_automation_scenario_manual.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ def test_automation_software_update_configuration(self, resource_group):
})

sub = '/subscriptions/' + self.get_subscription_id()
vm_id = self.cmd('vm create -n {vm_name} -g {rg} --image ubuntults --generate-ssh-key --nsg-rule NONE --location "West US 2"').get_output_in_json()['id']
vm_id = self.cmd('vm create -n {vm_name} -g {rg} --image Canonical:UbuntuServer:18.04-LTS:latest --generate-ssh-key --nsg-rule NONE --location "West US 2"').get_output_in_json()['id']
self.kwargs.update({
'vm_id': vm_id,
'sub': sub,
Expand Down
2 changes: 1 addition & 1 deletion src/bastion/azext_bastion/tests/latest/test_bastion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def test_bastion_host_crud(self):
self.cmd("network vnet create -n {vnet_name} -g {rg} --subnet-name AzureBastionSubnet")
self.cmd("network vnet subnet create -n {subnet_name} -g {rg} --vnet-name {vnet_name} --address-prefixes 10.0.2.0/24")
self.cmd("network public-ip create -n {ip_name} -g {rg} --sku Standard")
self.cmd("vm create -n {vm_name} -g {rg} --vnet-name {vnet_name} --subnet {subnet_name} --nsg-rule None --image UbuntuLTS --authentication-type password --admin-username testadmin --admin-password TestPassword11!!")
self.cmd("vm create -n {vm_name} -g {rg} --vnet-name {vnet_name} --subnet {subnet_name} --nsg-rule None --image Canonical:UbuntuServer:18.04-LTS:latest --authentication-type password --admin-username testadmin --admin-password TestPassword11!!")

self.cmd(
"network bastion create -n {bastion_name} -g {rg} --public-ip-address {ip_name} --vnet-name {vnet_name} "
Expand Down
2 changes: 1 addition & 1 deletion src/image-copy/azext_imagecopy/tests/latest/test_image_copy_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def test_image_copy_locations(self, resource_group):
'loc2': 'australiaeast',
})

self.cmd('vm create -g {rg} -n {vm} --admin-username theuser --image centos --admin-password testPassword0 '
self.cmd('vm create -g {rg} -n {vm} --admin-username theuser --image OpenLogic:CentOS:7.5:latest --admin-password testPassword0 '
'--authentication-type password --nsg-rule NONE')
time.sleep(70)
self.cmd('vm deallocate -g {rg} -n {vm}')
Expand Down
4 changes: 2 additions & 2 deletions src/logz/azext_logz/tests/latest/test_logz_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def test_main_account_vm(self):
# create virtual machine
self.cmd(
"vm create -n {vm} -g {rg} \
--os-disk-name os-disk --image centos \
--os-disk-name os-disk --image OpenLogic:CentOS:7.5:latest \
--generate-ssh-keys --public-ip-sku standard",
checks=[
self.check("powerState", "VM running")
Expand Down Expand Up @@ -274,7 +274,7 @@ def test_sub_account_vm(self):
# create virtual machine
self.cmd(
"vm create -n {vm} -g {rg} \
--os-disk-name os-disk --image centos \
--os-disk-name os-disk --image OpenLogic:CentOS:7.5:latest \
--generate-ssh-keys --public-ip-sku standard",
checks=[
self.check("powerState", "VM running")
Expand Down
20 changes: 10 additions & 10 deletions src/vm-repair/azext_vm_repair/tests/latest/test_repair_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def test_vmrepair_LinuxManagedCreateRestore(self, resource_group):
})

# Create test VM
self.cmd('vm create -g {rg} -n {vm} --image UbuntuLTS --admin-username azureadmin --admin-password !Passw0rd2018')
self.cmd('vm create -g {rg} -n {vm} --image Canonical:UbuntuServer:18.04-LTS:latest --admin-username azureadmin --admin-password !Passw0rd2018')
vms = self.cmd('vm list -g {rg} -o json').get_output_in_json()
# Something wrong with vm create command if it fails here
assert len(vms) == 1
Expand Down Expand Up @@ -124,7 +124,7 @@ def test_vmrepair_LinuxUnmanagedCreateRestore(self, resource_group):
})

# Create test VM
self.cmd('vm create -g {rg} -n {vm} --image UbuntuLTS --admin-username azureadmin --admin-password !Passw0rd2018 --use-unmanaged-disk')
self.cmd('vm create -g {rg} -n {vm} --image Canonical:UbuntuServer:18.04-LTS:latest --admin-username azureadmin --admin-password !Passw0rd2018 --use-unmanaged-disk')
vms = self.cmd('vm list -g {rg} -o json').get_output_in_json()
# Something wrong with vm create command if it fails here
assert len(vms) == 1
Expand Down Expand Up @@ -226,7 +226,7 @@ def test_vmrepair_LinuxManagedCreateRestorePublicIp(self, resource_group):
})

# Create test VM
self.cmd('vm create -g {rg} -n {vm} --image UbuntuLTS --admin-username azureadmin --admin-password !Passw0rd2018')
self.cmd('vm create -g {rg} -n {vm} --image Canonical:UbuntuServer:18.04-LTS:latest --admin-username azureadmin --admin-password !Passw0rd2018')
vms = self.cmd('vm list -g {rg} -o json').get_output_in_json()
# Something wrong with vm create command if it fails here
assert len(vms) == 1
Expand Down Expand Up @@ -260,7 +260,7 @@ def test_vmrepair_LinuxUnmanagedCreateRestorePublicIp(self, resource_group):
})

# Create test VM
self.cmd('vm create -g {rg} -n {vm} --image UbuntuLTS --admin-username azureadmin --admin-password !Passw0rd2018 --use-unmanaged-disk')
self.cmd('vm create -g {rg} -n {vm} --image Canonical:UbuntuServer:18.04-LTS:latest --admin-username azureadmin --admin-password !Passw0rd2018 --use-unmanaged-disk')
vms = self.cmd('vm list -g {rg} -o json').get_output_in_json()
# Something wrong with vm create command if it fails here
assert len(vms) == 1
Expand Down Expand Up @@ -351,7 +351,7 @@ def test_vmrepair_LinuxSinglepassKekEncryptedManagedDiskCreateRestore(self, reso
})

# Create test VM
self.cmd('vm create -g {rg} -n {vm} --image UbuntuLTS --admin-username azureadmin --admin-password !Passw0rd2018 --size Standard_D2s_v3')
self.cmd('vm create -g {rg} -n {vm} --image Canonical:UbuntuServer:18.04-LTS:latest --admin-username azureadmin --admin-password !Passw0rd2018 --size Standard_D2s_v3')
vms = self.cmd('vm list -g {rg} -o json').get_output_in_json()
# Something wrong with vm create command if it fails here
assert len(vms) == 1
Expand Down Expand Up @@ -450,7 +450,7 @@ def test_vmrepair_LinuxSinglepassNoKekEncryptedManagedDiskCreateRestoreTest(self
})

# Create test VM
self.cmd('vm create -g {rg} -n {vm} --image UbuntuLTS --admin-username azureadmin --admin-password !Passw0rd2018 --size Standard_D2s_v3')
self.cmd('vm create -g {rg} -n {vm} --image Canonical:UbuntuServer:18.04-LTS:latest --admin-username azureadmin --admin-password !Passw0rd2018 --size Standard_D2s_v3')
vms = self.cmd('vm list -g {rg} -o json').get_output_in_json()
# Something wrong with vm create command if it fails here
assert len(vms) == 1
Expand Down Expand Up @@ -517,7 +517,7 @@ def test_vmrepair_LinuxRunHelloWorld(self, resource_group):
})

# Create test VM
self.cmd('vm create -g {rg} -n {vm} --admin-username azureadmin --image UbuntuLTS --admin-password !Passw0rd2018')
self.cmd('vm create -g {rg} -n {vm} --admin-username azureadmin --image Canonical:UbuntuServer:18.04-LTS:latest --admin-password !Passw0rd2018')
vms = self.cmd('vm list -g {rg} -o json').get_output_in_json()
# Something wrong with vm create command if it fails here
assert len(vms) == 1
Expand Down Expand Up @@ -573,7 +573,7 @@ def test_vmrepair_LinuxSinglepassKekEncryptedManagedDiskCreateRestoreRHEL8(self,
})

# Create test VM
self.cmd('vm create -g {rg} -n {vm} --image UbuntuLTS --admin-username azureadmin --admin-password !Passw0rd2018 --size Standard_D2s_v3')
self.cmd('vm create -g {rg} -n {vm} --image Canonical:UbuntuServer:18.04-LTS:latest --admin-username azureadmin --admin-password !Passw0rd2018 --size Standard_D2s_v3')
vms = self.cmd('vm list -g {rg} -o json').get_output_in_json()
# Something wrong with vm create command if it fails here
assert len(vms) == 1
Expand Down Expand Up @@ -626,7 +626,7 @@ def test_vmrepair_LinuxSinglepassNoKekEncryptedManagedDiskCreateRestoreTestSLES1
})

# Create test VM
self.cmd('vm create -g {rg} -n {vm} --image UbuntuLTS --admin-username azureadmin --admin-password !Passw0rd2018 --size Standard_D2s_v3')
self.cmd('vm create -g {rg} -n {vm} --image Canonical:UbuntuServer:18.04-LTS:latest --admin-username azureadmin --admin-password !Passw0rd2018 --size Standard_D2s_v3')
vms = self.cmd('vm list -g {rg} -o json').get_output_in_json()
# Something wrong with vm create command if it fails here
assert len(vms) == 1
Expand Down Expand Up @@ -671,7 +671,7 @@ def test_vmrepair_LinuxManagedCreateRestoreOracle8PublicIp(self, resource_group)
})

# Create test VM
self.cmd('vm create -g {rg} -n {vm} --image UbuntuLTS --admin-username azureadmin --admin-password !Passw0rd2018')
self.cmd('vm create -g {rg} -n {vm} --image Canonical:UbuntuServer:18.04-LTS:latest --admin-username azureadmin --admin-password !Passw0rd2018')
vms = self.cmd('vm list -g {rg} -o json').get_output_in_json()
# Something wrong with vm create command if it fails here
assert len(vms) == 1
Expand Down