-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update API for Aks Edge Essentials #6873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @9lash, |
|
Draft |
| =============== | ||
| 1.5.3 | ||
| ++++++ | ||
| * Add support to get AKS-EE kubernetes distro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is suggested to specify the related command of this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no command related to this change. This change introduces support for a new infrastructure and distribution. Basically, whenever the regular onboarding command az connectedk8s connect command is run on aks_edge_essential infrastructure (node), this change will return the appropriate name of the distribution for aks-edge-essential node.
|
Please add test for this new feature. |
When you do kubectl get nodes on that infrastructure, you get an api response. In the infrastructure, the distro name is aks-edge-k3s. The test is dependent on the underlying infrastructure. We worked with the customer on validating this feature on that particular infrastructure. It passed the validation for the aks-edge-essentials scenario where this feature was tested on on-prem server with aks-edge-k3s/k8s configuration. |
|
[Release] Update index.json for extension [ connectedk8s ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=99710&view=results |
This PR updates the get calls for annotations to provide distribution names for aks-edge-k3s and aks-edge-k8s.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.