Skip to content

Conversation

@9lash
Copy link
Contributor

@9lash 9lash commented Oct 18, 2023

This PR updates the get calls for annotations to provide distribution names for aks-edge-k3s and aks-edge-k8s.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Oct 18, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @9lash,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 18, 2023

Draft

@9lash 9lash changed the title [Draft] Update API for Aks Edge Essentials Update API for Aks Edge Essentials Oct 23, 2023
===============
1.5.3
++++++
* Add support to get AKS-EE kubernetes distro
Copy link
Contributor

@yanzhudd yanzhudd Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is suggested to specify the related command of this change.

Copy link
Contributor Author

@9lash 9lash Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no command related to this change. This change introduces support for a new infrastructure and distribution. Basically, whenever the regular onboarding command az connectedk8s connect command is run on aks_edge_essential infrastructure (node), this change will return the appropriate name of the distribution for aks-edge-essential node.

@yanzhudd
Copy link
Contributor

Please add test for this new feature.

@9lash
Copy link
Contributor Author

9lash commented Oct 25, 2023

Please add test for this new feature.

When you do kubectl get nodes on that infrastructure, you get an api response. In the infrastructure, the distro name is aks-edge-k3s. The test is dependent on the underlying infrastructure. We worked with the customer on validating this feature on that particular infrastructure. It passed the validation for the aks-edge-essentials scenario where this feature was tested on on-prem server with aks-edge-k3s/k8s configuration.

@yanzhudd yanzhudd merged commit 07b71f9 into Azure:main Oct 25, 2023
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ connectedk8s ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=99710&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants