[containerapp] Hide containerapps and jobs env vars on create and update #6867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @p-bouchon, |
microsoft-github-policy-service
bot
requested review from
wangzelin007,
yanzhudd and
yonzhan
Collaborator
|
containerapp |
microsoft-github-policy-service
bot
requested review from
jsntcy and
zhoxing-ms
microsoft-github-policy-service
bot
requested review from
Greedygre,
JennyLawrance,
Juliehzl,
chinadragon0515,
ebencarek,
howang-ms,
jijohn14,
pagariyaalok,
ruslany,
sanchitmehta,
torosent,
vinisoto and
vturecek
Greedygre
reviewed
Oct 18, 2023
Greedygre
reviewed
Oct 18, 2023
Greedygre
reviewed
Oct 18, 2023
added 2 commits
October 18, 2023 10:37
Contributor
|
Hi @p-bouchon Please fix the static analysis. |
Greedygre
reviewed
Oct 19, 2023
Greedygre
reviewed
Oct 19, 2023
Greedygre
reviewed
Oct 19, 2023
Contributor
|
Hi @Juliehzl |
Greedygre
reviewed
Oct 24, 2023
Greedygre
reviewed
Oct 24, 2023
Greedygre
reviewed
Oct 25, 2023
| g.custom_command('delete', 'delete_containerapp', supports_no_wait=True, confirmation=True, exception_handler=ex_handler_factory()) | ||
| g.custom_command('exec', 'containerapp_ssh', validator=validate_ssh) | ||
| g.custom_command('up', 'containerapp_up', supports_no_wait=False, exception_handler=ex_handler_factory()) | ||
| g.custom_command('up', 'containerapp_up', supports_no_wait=False, exception_handler=ex_handler_factory(), transform=transform_sensitive_values) |
Contributor
There was a problem hiding this comment.
please remove the transform=transform_sensitive_values for up is not needed.
Greedygre
reviewed
Oct 25, 2023
Greedygre
approved these changes
Oct 25, 2023
Greedygre
reviewed
Oct 25, 2023
Juliehzl
reviewed
Oct 25, 2023
src/containerapp/HISTORY.rst
Outdated
| * 'az containerapp replica count', returns the replica count of a container app | ||
| * [Breaking Change] 'az containerapp job create': add default values for container app job properties --replica-completion-count, --replica-retry-limit, --replica-timeout, --parallelism, --min-executions, --max-executions, --polling-interval | ||
| * 'az containerapp create/update': hide environment variables, scale rules metadata | ||
| * 'az containerapp job create/update': hide environment variables, scale rules metadata |
Contributor
There was a problem hiding this comment.
add eventTriggerConfig for job
Greedygre
reviewed
Oct 25, 2023
Juliehzl
approved these changes
Oct 25, 2023
Contributor
|
Hi @yanzhudd Could you please help to review and merge this PR? Thanks!! |
Contributor
|
please rerun test in live mode and upload the recording file. |
yanzhudd
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.