Skip to content

Conversation

@mikehang-msft
Copy link
Contributor


Update ACS Rooms Azure CLI to new version 1.1.0b1 to Support PSTN Dial-Out Feature

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • [x ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [x ] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Oct 16, 2023

⚠️Azure CLI Extensions Breaking Change Test
⚠️communication
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd communication rooms create cmd communication rooms create added parameter pstn_dial_out_enabled
⚠️ 1006 - ParaAdd communication rooms update cmd communication rooms update added parameter pstn_dial_out_enabled

@azure-client-tools-bot-prd
Copy link

Hi @mikehang-msft,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 16, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@mikehang-msft
Copy link
Contributor Author

Hi @yonzhan, as we are releasing other SDKs, we are looking for a review and approval for Azure CLI as well. Can you please review this PR for us?

@mikehang-msft
Copy link
Contributor Author

Hi @zhoxing-ms and @yanzhudd, can you please review this PR? Our team has a deadline to release the SDK on Oct 31st, 2023. Much appreciated if you can merged the change in ASAP.

@jsntcy
Copy link
Member

jsntcy commented Oct 26, 2023

Hi @zhoxing-ms and @yanzhudd, can you please review this PR? Our team has a deadline to release the SDK on Oct 31st, 2023. Much appreciated if you can merged the change in ASAP.

Overall LGTM, please ensure the business logic is correct as we only review if the code complies with CLI conventions/styles or not.

@mikehang-msft
Copy link
Contributor Author

thanks @jsntcy. I have also added unit tests to cover newly added functions to ensure they are working as expected. Can you please merge the change for me if there is no additional changes?

@jsntcy jsntcy merged commit 7f2ce20 into Azure:main Oct 26, 2023
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ communication ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=100014&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants