-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update ACS Rooms Azure CLI to new version 1.1.0b1 to Support PSTN Dial-Out Feature #6862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| communication rooms create | cmd communication rooms create added parameter pstn_dial_out_enabled |
||
| communication rooms update | cmd communication rooms update added parameter pstn_dial_out_enabled |
|
Hi @mikehang-msft, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
Hi @yonzhan, as we are releasing other SDKs, we are looking for a review and approval for Azure CLI as well. Can you please review this PR for us? |
|
Hi @zhoxing-ms and @yanzhudd, can you please review this PR? Our team has a deadline to release the SDK on Oct 31st, 2023. Much appreciated if you can merged the change in ASAP. |
Overall LGTM, please ensure the business logic is correct as we only review if the code complies with CLI conventions/styles or not. |
|
thanks @jsntcy. I have also added unit tests to cover newly added functions to ensure they are working as expected. Can you please merge the change for me if there is no additional changes? |
|
[Release] Update index.json for extension [ communication ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=100014&view=results |
Update ACS Rooms Azure CLI to new version 1.1.0b1 to Support PSTN Dial-Out Feature
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.