AKS: Implement support to perform Azure container storage operations #6837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anagedclusterdecorator obj
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks create | cmd aks create added parameter enable_azure_container_storage |
||
| aks create | cmd aks create added parameter storage_pool_name |
||
| aks create | cmd aks create added parameter storage_pool_option |
||
| aks create | cmd aks create added parameter storage_pool_size |
||
| aks create | cmd aks create added parameter storage_pool_sku |
||
| aks update | cmd aks update added parameter azure_container_storage_nodepools |
||
| aks update | cmd aks update added parameter disable_azure_container_storage |
||
| aks update | cmd aks update added parameter enable_azure_container_storage |
||
| aks update | cmd aks update added parameter storage_pool_name |
||
| aks update | cmd aks update added parameter storage_pool_option |
||
| aks update | cmd aks update added parameter storage_pool_size |
||
| aks update | cmd aks update added parameter storage_pool_sku |
|
Hi @mukhoakash, |
microsoft-github-policy-service
bot
requested review from
yanzhudd,
yonzhan and
zhoxing-ms
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
FumingZhang
reviewed
Oct 10, 2023
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
Please add a live test case (see examples in test_aks_commands.py) for the change
…ate and update added
mukhoakash
force-pushed
the
acstor_cli
branch
from
c9b2ef3 to
a19da97
Compare
…logs. Improving the regex to validate float storage pool size
…tself. Add nodepool validation. Add check before update to ensure extension isn't already installed. Renamed a few functions. Added check to ensure whether to create storage pool of type requested based on the cluster and role assignments. Added tests and constants.
mukhoakash
force-pushed
the
acstor_cli
branch
from
142ff9e to
9914bc5
Compare
mukhoakash
force-pushed
the
acstor_cli
branch
from
ca30bef to
03f8527
Compare
mukhoakash
force-pushed
the
acstor_cli
branch
from
03f8527 to
ac95736
Compare
yanzhudd
reviewed
Oct 19, 2023
yanzhudd
reviewed
Oct 19, 2023
yanzhudd
approved these changes
Oct 19, 2023
Collaborator
|
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=98134&view=results |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.