-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[AKS Fleet] Update for Fleet identity options. #6830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kairu-ms
merged 23 commits into
Azure:main
from
Ealianis:sehobbs/fleet-identity-updates
Oct 17, 2023
Merged
[AKS Fleet] Update for Fleet identity options. #6830
kairu-ms
merged 23 commits into
Azure:main
from
Ealianis:sehobbs/fleet-identity-updates
Oct 17, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌Azure CLI Extensions Breaking Change Test
|
Collaborator
|
AKS Fleet |
Member
|
Implementation lgtm @Ealianis , is it possible to add test recording coverage for the update cases? |
…ller time for fleet.create.
jim-minter
reviewed
Oct 13, 2023
kairu-ms
reviewed
Oct 16, 2023
kairu-ms
reviewed
Oct 16, 2023
Contributor
|
@Ealianis is it ready to release? |
kairu-ms
approved these changes
Oct 17, 2023
Collaborator
|
[Release] Update index.json for extension [ fleet ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=97215&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az fleetGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.