Skip to content

Conversation

@Ealianis
Copy link
Contributor

@Ealianis Ealianis commented Oct 3, 2023


Related command

az fleet

  • Resolved issue caused by having a "none" value passed for the MSI identity dictionary.
  • Resolved issues around MSI in create / patch scenario. Creates will PUT (override) the --enabled-managed-identity & --assign-identity options. Updates will PATCH said options.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Oct 3, 2023

❌Azure CLI Extensions Breaking Change Test
❌fleet
rule cmd_name rule_message suggest_message
1003 - CmdPropAdd fleet delete cmd fleet delete added property confirmation please remove property confirmation for cmd fleet delete
1003 - CmdPropAdd fleet member delete cmd fleet member delete added property confirmation please remove property confirmation for cmd fleet member delete
1008 - ParaPropAdd fleet update cmd fleet update update parameter enable_managed_identity: added property choices=['false', 'true'] please remove property choices=['false', 'true'] for parameter enable_managed_identity of cmd fleet update
1007 - ParaRemove fleet updaterun create cmd fleet updaterun create removed parameter update_strategy_id please add back parameter update_strategy_id for cmd fleet updaterun create
1003 - CmdPropAdd fleet updaterun delete cmd fleet updaterun delete added property confirmation please remove property confirmation for cmd fleet updaterun delete
1003 - CmdPropAdd fleet updatestrategy delete cmd fleet updatestrategy delete added property confirmation please remove property confirmation for cmd fleet updatestrategy delete
⚠️ 1006 - ParaAdd fleet delete cmd fleet delete added parameter yes
⚠️ 1006 - ParaAdd fleet member delete cmd fleet member delete added parameter yes
⚠️ 1008 - ParaPropAdd fleet update cmd fleet update update parameter enable_managed_identity: added property nargs=?
⚠️ 1006 - ParaAdd fleet updaterun create cmd fleet updaterun create added parameter update_strategy_name
⚠️ 1009 - ParaPropRemove fleet updaterun create cmd fleet updaterun create update parameter node_image_selection: removed property required=True
⚠️ 1006 - ParaAdd fleet updaterun delete cmd fleet updaterun delete added parameter yes
⚠️ 1006 - ParaAdd fleet updatestrategy delete cmd fleet updatestrategy delete added parameter yes

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 3, 2023

AKS Fleet

@jim-minter
Copy link
Member

Implementation lgtm @Ealianis , is it possible to add test recording coverage for the update cases?

@kairu-ms
Copy link
Contributor

@Ealianis is it ready to release?

@kairu-ms kairu-ms merged commit 68c1f06 into Azure:main Oct 17, 2023
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ fleet ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=97215&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants