[AKS Fleet] - Add support for UpgradeStrategy, Default Hubless, and NodeImageSelection by Ealianis · Pull Request #6818 · Azure/azure-cli-extensions

Ealianis · 2023-09-28T20:46:14Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az fleet
az fleet updaterun
az fleet upgradestrategy

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

[] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2023-09-28T20:46:16Z

❌Azure CLI Extensions Breaking Change Test

❌fleet

rule cmd_name rule_message suggest_message

❌ 1009 - ParaPropRemove fleet create cmd fleet create update parameter enable_managed_identity: removed property nargs=? please add back property nargs=? for parameter enable_managed_identity of cmd fleet create

❌ 1009 - ParaPropRemove fleet create cmd fleet create update parameter enable_private_cluster: removed property nargs=? please add back property nargs=? for parameter enable_private_cluster of cmd fleet create

❌ 1009 - ParaPropRemove fleet create cmd fleet create update parameter enable_vnet_integration: removed property nargs=? please add back property nargs=? for parameter enable_vnet_integration of cmd fleet create

❌ 1009 - ParaPropRemove fleet update cmd fleet update update parameter enable_managed_identity: removed property nargs=? please add back property nargs=? for parameter enable_managed_identity of cmd fleet update

❌ 1006 - ParaAdd fleet updaterun create cmd fleet updaterun create added parameter node_image_selection please remove parameter node_image_selection for cmd fleet updaterun create

❌ 1008 - ParaPropAdd fleet updaterun create cmd fleet updaterun create update parameter upgrade_type: added property choices=['Full', 'NodeImageOnly'] please remove property choices=['Full', 'NodeImageOnly'] for parameter upgrade_type of cmd fleet updaterun create

⚠️ 1006 - ParaAdd fleet create cmd fleet create added parameter enable_hub

⚠️ 1009 - ParaPropRemove fleet create cmd fleet create update parameter enable_managed_identity: removed property choices=['false', 'true']

⚠️ 1009 - ParaPropRemove fleet create cmd fleet create update parameter enable_private_cluster: removed property choices=['false', 'true']

⚠️ 1009 - ParaPropRemove fleet create cmd fleet create update parameter enable_vnet_integration: removed property choices=['false', 'true']

⚠️ 1006 - ParaAdd fleet update cmd fleet update added parameter no_wait

⚠️ 1009 - ParaPropRemove fleet update cmd fleet update update parameter enable_managed_identity: removed property choices=['false', 'true']

⚠️ 1006 - ParaAdd fleet updaterun create cmd fleet updaterun create added parameter update_strategy_id

⚠️ 1001 - CmdAdd fleet updaterun wait cmd fleet updaterun wait added

⚠️ 1011 - SubgroupAdd fleet updatestrategy sub group fleet updatestrategy added

azure-client-tools-bot-prd · 2023-09-28T20:46:19Z

Hi @Ealianis,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

yonzhan · 2023-09-28T20:46:25Z

AKS Fleet

src/fleet/HISTORY.rst

src/fleet/azext_fleet/_validators.py

src/fleet/azext_fleet/custom.py

src/fleet/azext_fleet/tests/latest/test_fleet_scenario.py

src/fleet/azext_fleet/tests/latest/test_validators.py

Co-authored-by: Jim Minter <jim-minter@users.noreply.github.com>

azclibot · 2023-10-01T06:03:32Z

[Release] Update index.json for extension [ fleet ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=93970&view=results

…odeImageSelection (Azure#6818) * Update SDK to 20230815 * Fixed async operation calls. Added test recording. * changed test region * Updated recording * default hubless * WIP - FleetUpdateStrategy, NodeImageSelection, UpgradeType. * test recording update. * version bump and notes * Temp - removed update strategy tests. * Update src/fleet/HISTORY.rst Co-authored-by: Jim Minter <jim-minter@users.noreply.github.com> * Update src/fleet/HISTORY.rst Co-authored-by: Jim Minter <jim-minter@users.noreply.github.com> * Update src/fleet/azext_fleet/_validators.py Co-authored-by: Jim Minter <jim-minter@users.noreply.github.com> * added help text * Command made async. Made MSI support hub agnostic. * added -hub true to existing test scenario * Updated fleet_test_scenario * Added updatestrategy test. * Updated test recording. * Added tests, updated help text. * remove location field for fleet scenario test * wip: update stratget * bug fix * lint fixes * removed validator references * fix updatestrategy create * bug fix * revert and add check * add update strategy support in updaterun * fixed operation group * lint fix * lint fix * fix * update tests * fix test * fix test * style fix * fix test * static code fixes * fix static analysis * fix static analysis * fix recording * fix test --------- Co-authored-by: Sean Hobbs <sehobbs@microsoft.com> Co-authored-by: Jim Minter <jim-minter@users.noreply.github.com> Co-authored-by: Ubuntu <pdaru@devbox.14e411brg2pe1mavtw0j3pfyvf.xx.internal.cloudapp.net> Co-authored-by: pdaru <pdaru@microsoft.com>

azure-client-tools-bot-prd bot added this to the October 2023 (2023-11-15) milestone Sep 28, 2023

microsoft-github-policy-service bot requested review from yanzhudd and zhoxing-ms September 28, 2023 20:46

microsoft-github-policy-service bot requested review from FumingZhang and yonzhan September 28, 2023 20:46

microsoft-github-policy-service bot assigned yanzhudd and zhoxing-ms Sep 28, 2023

microsoft-github-policy-service bot added Auto-Assign Auto assign by bot AKS labels Sep 28, 2023

jim-minter suggested changes Sep 28, 2023

View reviewed changes

yonzhan requested a review from kairu-ms September 29, 2023 22:57

Sean Hobbs and others added 16 commits September 30, 2023 01:35

Update SDK to 20230815

5989a6a

Fixed async operation calls. Added test recording.

05f88cd

changed test region

4bec899

Updated recording

7d158cf

default hubless

9ecee25

WIP - FleetUpdateStrategy, NodeImageSelection, UpgradeType.

eceab1d

test recording update.

defd5ce

version bump and notes

09bd714

Temp - removed update strategy tests.

48168cd

Update src/fleet/HISTORY.rst

f3c9a74

Co-authored-by: Jim Minter <jim-minter@users.noreply.github.com>

Update src/fleet/HISTORY.rst

58aeaeb

Co-authored-by: Jim Minter <jim-minter@users.noreply.github.com>

Update src/fleet/azext_fleet/_validators.py

56f9fa2

Co-authored-by: Jim Minter <jim-minter@users.noreply.github.com>

added help text

eb66bd7

Command made async. Made MSI support hub agnostic.

527bf14

added -hub true to existing test scenario

4ec4130

Updated fleet_test_scenario

96a8a5b

Sean Hobbs and others added 18 commits September 30, 2023 01:35

Added tests, updated help text.

baec951

remove location field for fleet scenario test

51fa613

wip: update stratget

f0fe1b9

bug fix

4011e55

lint fixes

949c404

removed validator references

18eccda

fix updatestrategy create

ad7ee68

bug fix

f767ccf

revert and add check

f767f58

add update strategy support in updaterun

49e3fa5

fixed operation group

f6c917f

lint fix

bee0ce5

lint fix

82f106e

fix

26fd723

update tests

1613c79

fix test

15191e9

fix test

ca34e89

style fix

624c1cd

pdaru deleted the sehobbs/fleet-hubless-and-nc branch September 30, 2023 01:36

pdaru and others added 6 commits September 30, 2023 02:19

fix test

350586d

static code fixes

3449758

fix static analysis

3c804e6

fix static analysis

6305716

fix recording

942656b

fix test

c48a355

Ealianis marked this pull request as ready for review October 1, 2023 04:40

kairu-ms approved these changes Oct 1, 2023

View reviewed changes

kairu-ms merged commit b61edbb into Azure:main Oct 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AKS Fleet] - Add support for UpgradeStrategy, Default Hubless, and NodeImageSelection#6818

[AKS Fleet] - Add support for UpgradeStrategy, Default Hubless, and NodeImageSelection#6818
kairu-ms merged 42 commits intoAzure:mainfrom
Ealianis:sehobbs/fleet-hubless-and-nc

Ealianis commented Sep 28, 2023 •

edited

Loading

Uh oh!

azure-client-tools-bot-prd bot commented Sep 28, 2023 •

edited

Loading

Uh oh!

azure-client-tools-bot-prd bot commented Sep 28, 2023

Uh oh!

yonzhan commented Sep 28, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azclibot commented Oct 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

Ealianis commented Sep 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related command

General Guidelines

About Extension Publish

Uh oh!

azure-client-tools-bot-prd bot commented Sep 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-client-tools-bot-prd bot commented Sep 28, 2023

Uh oh!

yonzhan commented Sep 28, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azclibot commented Oct 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Ealianis commented Sep 28, 2023 •

edited

Loading

azure-client-tools-bot-prd bot commented Sep 28, 2023 •

edited

Loading