Add enable ASM egress gateway commands for az aks mesh#6768
Merged
yanzhudd merged 20 commits intoAzure:mainfrom Sep 19, 2023
nshankar13:nshankar/add-asm-egress-cli-commands
Merged
Add enable ASM egress gateway commands for az aks mesh#6768yanzhudd merged 20 commits intoAzure:mainfrom nshankar13:nshankar/add-asm-egress-cli-commands
yanzhudd merged 20 commits intoAzure:mainfrom
nshankar13:nshankar/add-asm-egress-cli-commands
Conversation
added 2 commits
September 15, 2023 10:21
Signed-off-by: nshankar <nshankar@microsoft.ghe.com>
Signed-off-by: nshankar <nshankar@microsoft.ghe.com>
nshankar13
requested review from
FumingZhang and
andyliuliming
as code owners
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks mesh disable-egress-gateway | cmd aks mesh disable-egress-gateway added |
||
| aks mesh enable-egress-gateway | cmd aks mesh enable-egress-gateway added |
|
Hi @nshankar13, |
microsoft-github-policy-service
bot
requested review from
yanzhudd,
yonzhan and
zhoxing-ms
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
added 15 commits
September 15, 2023 15:39
Signed-off-by: nshankar <nshankar@microsoft.ghe.com>
Signed-off-by: nshankar <nshankar@microsoft.ghe.com>
Signed-off-by: nshankar <nshankar@microsoft.ghe.com>
Signed-off-by: nshankar <nshankar@microsoft.ghe.com>
Signed-off-by: nshankar <nshankar@microsoft.ghe.com>
Signed-off-by: nshankar <nshankar@microsoft.ghe.com>
Signed-off-by: nshankar <nshankar@microsoft.ghe.com>
Signed-off-by: nshankar <nshankar@microsoft.ghe.com>
Signed-off-by: nshankar <nshankar@microsoft.ghe.com>
Signed-off-by: nshankar <nshankar@microsoft.ghe.com>
Signed-off-by: nshankar <nshankar@microsoft.ghe.com>
Signed-off-by: nshankar <nshankar@microsoft.ghe.com>
Signed-off-by: nshankar <nshankar@microsoft.ghe.com>
Signed-off-by: nshankar <nshankar@microsoft.ghe.com>
Signed-off-by: nshankar <nshankar@microsoft.ghe.com>
added 2 commits
September 16, 2023 10:59
Signed-off-by: nshankar <nshankar@microsoft.ghe.com>
Signed-off-by: nshankar <nshankar@microsoft.ghe.com>
Contributor
Author
|
@andyliuliming @FumingZhang @zhoxing-ms @yanzhudd @yonzhan need some urgent reviews on this as we are trying to meet 9/19 deadline for CLI changes and to get this into the GA API changes in |
FumingZhang
reviewed
Sep 18, 2023
|
|
||
| @AllowLargeResponse() | ||
| @AKSCustomResourceGroupPreparer(random_name_length=17, name_prefix='clitest', location='westus2') | ||
| def test_aks_azure_service_mesh_with_egress_gateway(self, resource_group, resource_group_location): |
Signed-off-by: nshankar <nshankar@microsoft.ghe.com>
Contributor
|
It is suggested to add some details of changes in #6768 (comment) |
Contributor
|
Please add change logs in HISTORY.rst. If you want to release a new version, please change version in setup.py file. |
Contributor
Author
|
@FumingZhang @yanzhudd updated HISTORY.rst and setup.py. |
Collaborator
|
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=91341&view=results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.