capture az error output and auto-fix the script #6750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gpt for it to suggest corrections, etc
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @sulixu, |
microsoft-github-policy-service
bot
requested review from
yanzhudd and
zhoxing-ms
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
FumingZhang
reviewed
Sep 13, 2023
Comment on lines
132
to
133
| if IS_MS_WINDOWS: | ||
| cmd = ["powershell", "-Command", script_content] |
Member
There was a problem hiding this comment.
Seems this is never reached. Or according to description, should just return/raise exception?
Contributor
Author
There was a problem hiding this comment.
make sense, just add raise exception if this func is called from windows
FumingZhang
reviewed
Sep 14, 2023
| if not pattern in output: | ||
| raise CliTestError(f"Output from aks copilot did not contain '{pattern}'. Output:\n{output}") | ||
|
|
||
| def test_detect_az_error(self): |
Member
There was a problem hiding this comment.
Could you put these test cases to some other file? The test cases in test_aks_commands.py are live test cases.
zhoxing-ms
approved these changes
Sep 15, 2023
sulixu
added a commit
to sulixu/azure-cli-extensions
that referenced
this pull request
Sep 19, 2023
This reverts commit 7ebb030.
This was referenced Sep 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhance run script to capture error output, which we can feed to chatgpt to suggest corrections, etc
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks copilot
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.