Skip to content

{Service Connector}: fix passwordless postgres cmd #6748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kairu-ms merged 2 commits into from
Sep 13, 2023
Merged

{Service Connector}: fix passwordless postgres cmd #6748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a91943
fix service connector passwordless postgres
xfz11 Sep 12, 2023
e142a13
fix param error
xfz11 Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/serviceconnector-passwordless/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

Release History
===============
0.3.10
++++++
* make some improvements.

0.3.9
++++++
* Support `--customized-keys` and make some improvements.
Expand Down
2 changes: 1 addition & 1 deletion src/serviceconnector-passwordless/azext_serviceconnector_passwordless/_credential_free.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,7 +857,7 @@ def enable_target_aad_auth(self):
def check_db_existence(self):
try:
db_info = run_cli_cmd(
'az postgres server db show --ids {}'.format(self.target_id))
'az postgres db show --ids {} -n {}'.format(self.target_id, self.dbname))
if db_info is None:
e = ResourceNotFoundError(
"No database found with name {}".format(self.dbname))
Expand Down
2 changes: 1 addition & 1 deletion src/serviceconnector-passwordless/azext_serviceconnector_passwordless/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
# --------------------------------------------------------------------------------------------


VERSION = '0.3.9'
VERSION = '0.3.10'
NAME = 'serviceconnector-passwordless'
4 changes: 2 additions & 2 deletions src/serviceconnector-passwordless/azext_serviceconnector_passwordless/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ def connection_create_ext(cmd, client, # pylint: disable=too-many-locals,too-ma
service_endpoint=None,
private_endpoint=None,
store_in_connection_string=False,
customized_keys=None,
new_addon=False, no_wait=False,
yes=False,
# Resource.KubernetesCluster
cluster=None, scope=None, enable_csi=False,
customized_keys=None,
site=None, # Resource.WebApp
spring=None, app=None, deployment='default', # Resource.SpringCloud
# Resource.*Postgres, Resource.*Sql*
Expand Down Expand Up @@ -58,8 +58,8 @@ def local_connection_create_ext(cmd, client, # pylint: disable=too-many-locals,
secret_auth_info=None, secret_auth_info_auto=None,
user_account_auth_info=None, # new auth info
service_principal_auth_info_secret=None,
customized_keys=None,
no_wait=False,
customized_keys=None,
yes=False,
# Resource.*Postgres, Resource.*Sql*
server=None, database=None,
Expand Down