Skip to content

Conversation

@jonathanbrenes
Copy link
Contributor

@jonathanbrenes jonathanbrenes commented Sep 7, 2023

Make sure the resource created for the Public IP match the name repair-_PublicIP


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az vm repair

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required) yes
  • Have you run python scripts/ci/test_index.py -q locally? yes

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Sep 7, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @jonathanbrenes,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 7, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link
Member

@haagha haagha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@jonathanbrenes jonathanbrenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version and HISTORY.rst changed as requested

@zhoxing-ms zhoxing-ms merged commit 57766a7 into Azure:main Sep 13, 2023
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ vm-repair ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=89855&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Compute

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants