-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Make sure the resource created for the Public IP match the name repai… #6737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @jonathanbrenes, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
haagha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, If you want this to change to be published you have to update version number and describe the update:
azure-cli-extensions/src/vm-repair/setup.py at jbrenes-fix-publicip · jonathanbrenes/azure-cli-extensions (github.com)
azure-cli-extensions/src/vm-repair/HISTORY.rst at jbrenes-fix-publicip · jonathanbrenes/azure-cli-extensions (github.com)
jonathanbrenes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version and HISTORY.rst changed as requested
|
[Release] Update index.json for extension [ vm-repair ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=89855&view=results |
Make sure the resource created for the Public IP match the name repair-_PublicIP
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az vm repair
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired) yespython scripts/ci/test_index.py -qlocally? yesAbout Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.