Skip to content

Conversation

@priyamshet
Copy link
Member

@priyamshet priyamshet commented Sep 6, 2023

  • adding test for kubernetescluster restart node command

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

- adding test for kubernetescluster restart node command
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Sep 6, 2023

❌Azure CLI Extensions Breaking Change Test
❌networkcloud
rule cmd_name rule_message suggest_message
1012 - SubgroupRemove networkcloud defaultcninetwork sub group networkcloud defaultcninetwork removed please confirm sub group networkcloud defaultcninetwork removed
1012 - SubgroupRemove networkcloud hybridakscluster sub group networkcloud hybridakscluster removed please confirm sub group networkcloud hybridakscluster removed

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 6, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@priyamshet priyamshet changed the title NetworkCloud updated to version 1.1.0 NetworkCloud updated to version 1.1.0 ( kubernetescluster restart node command, remove old resources) Sep 6, 2023
@priyamshet
Copy link
Member Author

@kairu-ms can we request review on this PR .

@kairu-ms
Copy link
Contributor

kairu-ms commented Sep 8, 2023

@kairu-ms can we request review on this PR .

@priyamshet Is this PR ready to merge and release?

@priyamshet
Copy link
Member Author

@kairu-ms yes this PR is ready to merge/release. Thank you

@kairu-ms kairu-ms merged commit 0bb4298 into Azure:main Sep 8, 2023
@azclibot
Copy link
Collaborator

azclibot commented Sep 8, 2023

[Release] Update index.json for extension [ networkcloud ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=89206&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants