Conversation
wyatt-troia-msft
requested review from
evelyn-ys,
jiasli,
jsntcy,
kairu-ms,
necusjz and
zhoxing-ms
as code owners
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @wyatt-troia-msft, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
ggaurav10
left a comment
ggaurav10
left a comment
There was a problem hiding this comment.
some cli flags which shouldn't be exposed are not suppressed.
| "Programming Language :: Python", | ||
| "Programming Language :: Python :: 3", | ||
| "Programming Language :: Python :: 3.6", | ||
| "Programming Language :: Python :: 3.7", | ||
| "Programming Language :: Python :: 3.8", |
There was a problem hiding this comment.
BTW the python version which less than 3.8 is not supported. Please update it as well
There was a problem hiding this comment.
Should I keep the line without any version of Python specified?
| "contacts": [ | ||
| { | ||
| "email": "azpycli@microsoft.com", | ||
| "name": "Microsoft Corporation", | ||
| "role": "author" | ||
| } | ||
| ], | ||
| "document_names": { | ||
| "description": "DESCRIPTION.rst" | ||
| }, | ||
| "project_urls": { | ||
| "Home": "https://github.com/Azure/azure-cli-extensions/tree/master/src/stack-hci-vm" | ||
| } |
There was a problem hiding this comment.
As the source code of this extension is not in Azure/azure-cli-extensions repo, please correct the descriptions here.
There was a problem hiding this comment.
What all do I need to correct?
There was a problem hiding this comment.
Is it okay if we remove the whole section?
@kairu-ms
There was a problem hiding this comment.
These metadata are retrieved from the extension source code. So you should correct them in the extension code.
ggaurav10
left a comment
ggaurav10
left a comment
There was a problem hiding this comment.
looks good from stack-hci-vm code perspective.
6 participants
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.