Skip to content

[Spring] Support war file deployment#6723

Merged
zhoxing-ms merged 15 commits intoAzure:mainfrom
yilims:main
Sep 7, 2023
Merged

[Spring] Support war file deployment#6723
zhoxing-ms merged 15 commits intoAzure:mainfrom
yilims:main

Conversation

@yilims
Copy link
Contributor

@yilims yilims commented Sep 4, 2023

Related command

az spring app deploy
az spring app deployment create
add new arg --server-version to support war file deployment in standard tier.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Sep 4, 2023

⚠️Azure CLI Extensions Breaking Change Test
⚠️spring
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd spring app deploy cmd spring app deploy added parameter server_version
⚠️ 1006 - ParaAdd spring app deployment create cmd spring app deployment create added parameter server_version

@azure-client-tools-bot-prd
Copy link

Hi @yilims,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@azure-client-tools-bot-prd
Copy link

Hi @yilims,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 4, 2023

Spring

@zhoxing-ms
Copy link
Contributor

Please take a look at this comment #6723 (comment)

@yilims
Copy link
Contributor Author

yilims commented Sep 6, 2023

Please take a look at this comment #6723 (comment)

Thanks @zhoxing-ms, I have added description for this PR:

Related command

az spring app deploy
az spring app deployment create
add new arg --server-version to support war file deployment in standard tier.

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented Sep 6, 2023

Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yilims
Copy link
Contributor Author

yilims commented Sep 6, 2023

Thanks @zhoxing-ms, I have updated HISTORY.rst

@zhoxing-ms
Copy link
Contributor

If you want to release a new extension version, please update the version in setup.py as well.

How about the setup.py file?

@yilims
Copy link
Contributor Author

yilims commented Sep 7, 2023

If you want to release a new extension version, please update the version in setup.py as well.

How about the setup.py file?

@zhoxing-ms, I don't want to release a new version for this PR. There's other new features developed by other folks, will be released with other features together.

@yilims yilims requested a review from zhoxing-ms September 7, 2023 05:54
@zhoxing-ms zhoxing-ms merged commit 546d379 into Azure:main Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants