Skip to content

{containerapp} az containerapp update fix list secret value for populate#6720

Merged
zhoxing-ms merged 4 commits intoAzure:mainfrom
Greedygre:xinyu/fix_list_secrets
Sep 4, 2023
Merged

{containerapp} az containerapp update fix list secret value for populate#6720
zhoxing-ms merged 4 commits intoAzure:mainfrom
Greedygre:xinyu/fix_list_secrets

Conversation

@Greedygre
Copy link
Contributor

@Greedygre Greedygre commented Sep 4, 2023


fix issue: #6712
This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

'az containerapp update': fix bug for populating secret value with --yaml

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Sep 4, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @Greedygre,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link

Hi @Greedygre,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 4, 2023

containerapp

@Greedygre
Copy link
Contributor Author

Hi @zhoxing-ms
Could you please help to review and approve this PR? Thanks!

@zhoxing-ms zhoxing-ms merged commit 53da6ed into Azure:main Sep 4, 2023
@azclibot
Copy link
Collaborator

azclibot commented Sep 4, 2023

[Release] Update index.json for extension [ containerapp ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=87919&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants