Skip to content

Conversation

@calvinhzy
Copy link
Member

@calvinhzy calvinhzy commented Sep 1, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Fix az network manager group static-member create cross-tenant --resource-id
Fix az network manager post-commit so it succeeds when no response body is returned
Fix #27299

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@calvinhzy calvinhzy self-assigned this Sep 1, 2023
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Sep 1, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @calvinhzy,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link

Hi @calvinhzy,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 1, 2023

Network-Manager

@microsoft-github-policy-service microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Sep 1, 2023
@calvinhzy calvinhzy changed the title [Network-Manager] az network manager group static-member create [Network-Manager] Fix #27299: az network manager group static-member create Sep 1, 2023
@calvinhzy calvinhzy marked this pull request as ready for review September 12, 2023 08:33
@calvinhzy calvinhzy changed the title [Network-Manager] Fix #27299: az network manager group static-member create [Network-Manager] Fix #27299: az network manager group static-member create and az network manager post-commit Sep 12, 2023
@calvinhzy calvinhzy merged commit 383495c into Azure:main Sep 13, 2023
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ network-manager ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=90003&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Network

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression for 'virtual-network-manager' extension, various commands

4 participants