Skip to content

Conversation

@jiashun0011
Copy link
Contributor

[AKS] az aks update: add new parameter --disable-workload-identity to disable Workload Identity


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 30, 2023

❌Azure CLI Extensions Breaking Change Test
❌aks-preview
rule cmd_name rule_message suggest_message
1009 - ParaPropRemove aks create cmd aks create update parameter enable_workload_identity: removed property nargs=? please add back property nargs=? for parameter enable_workload_identity of cmd aks create
1009 - ParaPropRemove aks update cmd aks update update parameter enable_workload_identity: removed property nargs=? please add back property nargs=? for parameter enable_workload_identity of cmd aks update
⚠️ 1009 - ParaPropRemove aks create cmd aks create update parameter enable_workload_identity: removed property choices=['false', 'true']
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter disable_workload_identity
⚠️ 1009 - ParaPropRemove aks update cmd aks update update parameter enable_workload_identity: removed property choices=['false', 'true']

@azure-client-tools-bot-prd
Copy link

Hi @jiashun0011,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link

Hi @jiashun0011,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 30, 2023

AKS

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please leave some notes in history.rst

disable_cmd = ' '.join([
'aks', 'update', '--resource-group={resource_group}', '--name={name}',
'--enable-workload-identity', 'False',
'--disable-workload-identity',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queued live test to validate the change.

c.argument('enable_pod_identity', action='store_true')
c.argument('enable_pod_identity_with_kubenet', action='store_true')
c.argument('enable_workload_identity', arg_type=get_three_state_flag(), is_preview=True)
c.argument('enable_workload_identity', action='store_true', is_preview=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifying parameter types may cause a breaking change, such as if --enable-workload-identity True was used in the automation script, it may no longer work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and in our stable cli, we already used enable + diable, though we will remove the preview extension in future, we still want to align it with stable version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, got it

@zhoxing-ms
Copy link
Contributor

@jiashun0011 Please resolve this conflict

@zhoxing-ms
Copy link
Contributor

#6706 (comment) If you want to release a new extension version for this PR, please also upgrade the version defined in the setup.py

@zhoxing-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jiashun0011
Copy link
Contributor Author

#6706 (comment) If you want to release a new extension version for this PR, please also upgrade the version defined in the setup.py

updated

@zhoxing-ms zhoxing-ms merged commit ad18aa5 into Azure:main Sep 13, 2023
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=90020&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants