Add cost-analysis preview CLI flag#6705
Merged
zhoxing-ms merged 1 commit intoAzure:mainfrom Sep 2, 2023
Merged
Conversation
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks create | cmd aks create added parameter enable_cost_analysis |
||
| aks update | cmd aks update added parameter disable_cost_analysis |
||
| aks update | cmd aks update added parameter enable_cost_analysis |
|
Hi @matthchr, |
babbageclunk
approved these changes
Aug 29, 2023
davefellows
reviewed
Aug 29, 2023
matthchr
force-pushed
the
matthchr/cost-analysis
branch
from
f0cbac4 to
22c3199
Compare
FumingZhang
reviewed
Aug 30, 2023
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
zhoxing-ms
reviewed
Aug 30, 2023
zhoxing-ms
reviewed
Aug 30, 2023
matthchr
force-pushed
the
matthchr/cost-analysis
branch
from
22c3199 to
4058540
Compare
matthchr
force-pushed
the
matthchr/cost-analysis
branch
from
4058540 to
12eb029
Compare
Member
Author
|
@zhoxing-ms What else needs to be done on this PR before it merges? If nothing, can we merge? |
zhoxing-ms
approved these changes
Sep 2, 2023
Collaborator
|
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=87794&view=results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.