{AKS} Update AKS tests to allow enable AAD legacy when creating cluster#6670
Closed
bingosummer wants to merge 1 commit intoAzure:mainfrom
Closed
{AKS} Update AKS tests to allow enable AAD legacy when creating cluster#6670bingosummer wants to merge 1 commit intoAzure:mainfrom
bingosummer wants to merge 1 commit intoAzure:mainfrom
Conversation
bingosummer
requested review from
FumingZhang and
andyliuliming
as code owners
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @bingosummer, |
microsoft-github-policy-service
bot
requested review from
yanzhudd,
yonzhan and
zhoxing-ms
Collaborator
|
AKS |
bingosummer
force-pushed
the
aks-aadv1-test
branch
from
eb1deaa to
85d48ab
Compare
FumingZhang
reviewed
Aug 22, 2023
| '--aad-server-app-secret fake-secret ' \ | ||
| '--aad-client-app-id 00000000-0000-0000-0000-000000000002 ' \ | ||
| '--aad-tenant-id d5b55040-0c14-48cc-a028-91457fc190d9 ' \ | ||
| '--aks-custom-headers AKSHTTPCustomFeatures=Microsoft.ContainerService/AADv1AllowCreate ' \ |
Member
|
some lb related cases failed in CI, could you please help take a look? @MartinForReal |
Contributor
|
I found several issues and I will raise a pr later in azure-cli and azure-cli-extension. |
Member
Author
|
@FumingZhang shall we merge this PR or hold on until @MartinForReal 's PR is merged? |
Contributor
|
I think so. Sorry for the delay. |
Contributor
|
pr has been merged. Could you please rerun the test? @bingosummer |
3 tasks
Member
|
Close as change has been performed by #6719 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR updates AKS tests to allow enable AAD legacy when creating cluster.