Skip to content

Conversation

@kairu-ms
Copy link
Contributor

@kairu-ms kairu-ms commented Aug 9, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

  • az vmware workload-network segment create: Removed the --port-name argument which is used by a read-only property.
  • az vmware privated-cloud identity-source: New command group to manage identity source.
  • az vmware private-cloud add-identity-source/delete-identity-source: Deprecated and redirect to az vmware private-cloud identity-source create/delete.
  • az vmware script-execution create: Fix bug for --output argument, it should accept a list of string values.
  • az vmware placement-policy vm update: Removed the --affinity-strength and --azure-hybrid-benefit arguments. They should only be used in vm-host update.
  • Use Get+Put operations for all the update commands.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 9, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @kairu-ms,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 9, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@yonzhan yonzhan requested a review from jsntcy August 9, 2023 04:47
@kairu-ms kairu-ms force-pushed the migrate-vmware branch 2 times, most recently from 6190318 to 106e48c Compare August 14, 2023 03:57
@kairu-ms kairu-ms marked this pull request as ready for review August 22, 2023 02:46
@kairu-ms kairu-ms requested a review from zhoxing-ms as a code owner August 22, 2023 02:46
@kairu-ms kairu-ms merged commit ca53b85 into Azure:main Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants