Skip to content

[ACR Query Extension] Bug fix: omitting login server endpoint suffix #6606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhoxing-ms merged 14 commits into from
Aug 22, 2023
Merged

[ACR Query Extension] Bug fix: omitting login server endpoint suffix #6606

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
5c3206e
Add validator to registry name
Aug 7, 2023
8c736ae
Remove insecure credential sharing
Aug 9, 2023
85501f5
Add mock tests
Aug 11, 2023
0eab77a
Add scenario test
Aug 11, 2023
b774c6e
Rewrite mock test file
Aug 12, 2023
f8f0e7c
Use acr library instead
Aug 16, 2023
127f385
Merge branch 'acr.query.bugfix' of https://github.com/CarolineNB/azur…
Aug 16, 2023
d3efb70
mock test
Aug 16, 2023
db718ca
Add white space and rename unit tests
Aug 16, 2023
c057918
Final iteration of mock tests
Aug 16, 2023
6792bb4
Final iteration of mock tests
Aug 16, 2023
d994f35
Update history text
Aug 17, 2023
e2c10f3
Change patch version number
Aug 17, 2023
0e698c7
Update setup.py version
Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/acrquery/azext_acrquery/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@
# Licensed under the MIT License. See License.txt in the project root for license information.
# --------------------------------------------------------------------------------------------

from azure.cli.command_modules.acs._validators import validate_registry_name

def load_arguments(self, _):

with self.argument_context('acr query') as c:
c.argument('registry_name', options_list=['--name', '-n'], help='The name of the container registry that the query is run against.')
c.argument('registry_name', options_list=['--name', '-n'], validator=validate_registry_name, help='The name of the container registry that the query is run against.')

@huanwu huanwu Aug 7, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test on it?

@huanwu huanwu Aug 17, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question, do we need update history.rst?

c.argument('repository', help='The repository that the query is run against. If no repository is provided, the query is run at the registry level.')
c.argument('kql_query', options_list=['--kql-query', '-q'], help='The KQL query to execute.')
c.argument('skip_token', help='Skip token to get the next page of the query if applicable.')
Expand Down
Loading