Skip to content

Conversation

@vineeth-thumma
Copy link
Contributor

@vineeth-thumma vineeth-thumma commented Aug 2, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 2, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @vineeth-thumma,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 2, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@vineeth-thumma vineeth-thumma changed the title OBO: arc mode in Guard connectedk8s: Add "arc "mode in Guard for using OBOservice Aug 3, 2023
@yonzhan yonzhan requested review from yanzhudd and zhoxing-ms August 3, 2023 00:53
@vineeth-thumma vineeth-thumma changed the title connectedk8s: Add "arc "mode in Guard for using OBOservice connectedk8s: Add "arc "mode in Guard for using OBO service Aug 3, 2023
@vineeth-thumma vineeth-thumma changed the title connectedk8s: Add "arc "mode in Guard for using OBO service [Work In Progress - Do Not Merge] Connectedk8s: Add "arc "mode in Guard for using OBO service Aug 3, 2023
@vineeth-thumma vineeth-thumma marked this pull request as ready for review August 3, 2023 20:04
Copy link

@julienstroheker julienstroheker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking PR for now. Since we want to wait before this getting merged.

@vineeth-thumma
Copy link
Contributor Author

Closed this in favor of #6675

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants