{CI} Fix command tree broken issue #6573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @wangzelin007, |
|
Hi @wangzelin007, |
Collaborator
|
CI |
microsoft-github-policy-service
bot
requested review from
JennyLawrance,
Juliehzl,
bebound,
chinadragon0515,
ebencarek,
howang-ms,
jiasli,
jijohn14,
jsntcy,
kairu-ms,
pagariyaalok,
ruslany,
sanchitmehta,
torosent,
vinisoto,
vturecek,
yanzhudd,
yonzhan and
zhoxing-ms
Contributor
|
It's better to update it here |
kairu-ms
approved these changes
Jul 28, 2023
evelyn-ys
approved these changes
Jul 28, 2023
Juliehzl
requested changes
Jul 28, 2023
Contributor
Juliehzl
left a comment
Juliehzl
left a comment
There was a problem hiding this comment.
we do not want to be a special case with such exclusion. Let's discuss for better solution next week.
Member
Author
Since our pipeline for updating the extension command index has been affected, I will merge this pr first.
|
wangzelin007
added a commit
that referenced
this pull request
Aug 9, 2023
This reverts commit 3df4a81.
wangzelin007
added a commit
to wangzelin007/azure-cli-extensions
that referenced
this pull request
Aug 9, 2023
This reverts commit 3df4a81.
wangzelin007
added a commit
that referenced
this pull request
Aug 11, 2023
* Revert "{CI} Update the --dependent-file parameter to be an optional argument to avoid introducing a breaking change. (#6521)"
This reverts commit b442cf0.
* Revert "{CI} Fix verify ref docs (#6507)"
This reverts commit f12d922.
* Revert "{CI} Fix command tree broken issue (#6573)"
This reverts commit 3df4a81.
* revert linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When two extensions have the same command, the following error will be reported:
Exception: Key: show already exists in containerapp. 2 extensions cannot have the same command!Temporarily skip the containerapp-preview extension to aviod this error.
Which will cause the containerapp-preview extension to be unable to use the dynamic load function.
That is, when using the unique command of containerapp-preview, the extension cannot be automatically prompted to install.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.