Skip to content

Conversation

@necusjz
Copy link
Member

@necusjz necusjz commented Jul 27, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Azure/aaz#251

6 commands

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@necusjz necusjz requested a review from kairu-ms as a code owner July 27, 2023 07:19
@necusjz necusjz self-assigned this Jul 27, 2023
@necusjz necusjz requested a review from jsntcy as a code owner July 27, 2023 07:19
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 27, 2023

❌Azure CLI Extensions Breaking Change Test
❌virtual-wan
rule cmd_name rule_message suggest_message
1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter address_prefixes: added property type please remove property type for parameter address_prefixes for cmd network vhub connection create
1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter allow_hub_to_remote_vnet_transit: added property type please remove property type for parameter allow_hub_to_remote_vnet_transit for cmd network vhub connection create
1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter allow_remote_vnet_to_use_hub_vnet_gateways: added property type please remove property type for parameter allow_remote_vnet_to_use_hub_vnet_gateways for cmd network vhub connection create
1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter associated_inbound_routemap: added property type please remove property type for parameter associated_inbound_routemap for cmd network vhub connection create
1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter associated_outbound_routemap: added property type please remove property type for parameter associated_outbound_routemap for cmd network vhub connection create
1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter associated_route_table: added property type please remove property type for parameter associated_route_table for cmd network vhub connection create
1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter connection_name: added property type please remove property type for parameter connection_name for cmd network vhub connection create
1009 - ParaPropRemove network vhub connection create cmd network vhub connection create update parameter connection_name: removed property id_part please add back property id_part for parameter connection_namefor cmdnetwork vhub connection create`
1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter enable_internet_security: added property type please remove property type for parameter enable_internet_security for cmd network vhub connection create
1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter labels: added property type please remove property type for parameter labels for cmd network vhub connection create
1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter next_hop_ip_address: added property type please remove property type for parameter next_hop_ip_address for cmd network vhub connection create
1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter no_wait: added property choices please remove property choices for parameter no_wait for cmd network vhub connection create
1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter no_wait: added property type please remove property type for parameter no_wait for cmd network vhub connection create
1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter propagated_route_tables: added property type please remove property type for parameter propagated_route_tables for cmd network vhub connection create
1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter remote_virtual_network: added property type please remove property type for parameter remote_virtual_network for cmd network vhub connection create
1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter resource_group_name: added property type please remove property type for parameter resource_group_name for cmd network vhub connection create
1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter route_name: added property type please remove property type for parameter route_name for cmd network vhub connection create
1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter virtual_hub_name: added property type please remove property type for parameter virtual_hub_name for cmd network vhub connection create
1009 - ParaPropRemove network vhub connection create cmd network vhub connection create update parameter virtual_hub_name: removed property id_part please add back property id_part for parameter virtual_hub_namefor cmdnetwork vhub connection create`
1008 - ParaPropAdd network vhub connection delete cmd network vhub connection delete update parameter connection_name: added property type please remove property type for parameter connection_name for cmd network vhub connection delete
1008 - ParaPropAdd network vhub connection delete cmd network vhub connection delete update parameter no_wait: added property choices please remove property choices for parameter no_wait for cmd network vhub connection delete
1008 - ParaPropAdd network vhub connection delete cmd network vhub connection delete update parameter no_wait: added property type please remove property type for parameter no_wait for cmd network vhub connection delete
1008 - ParaPropAdd network vhub connection delete cmd network vhub connection delete update parameter resource_group_name: added property type please remove property type for parameter resource_group_name for cmd network vhub connection delete
1008 - ParaPropAdd network vhub connection delete cmd network vhub connection delete update parameter virtual_hub_name: added property type please remove property type for parameter virtual_hub_name for cmd network vhub connection delete
1008 - ParaPropAdd network vhub connection list cmd network vhub connection list update parameter resource_group_name: added property type please remove property type for parameter resource_group_name for cmd network vhub connection list
1008 - ParaPropAdd network vhub connection list cmd network vhub connection list update parameter virtual_hub_name: added property type please remove property type for parameter virtual_hub_name for cmd network vhub connection list
1008 - ParaPropAdd network vhub connection show cmd network vhub connection show update parameter connection_name: added property type please remove property type for parameter connection_name for cmd network vhub connection show
1008 - ParaPropAdd network vhub connection show cmd network vhub connection show update parameter resource_group_name: added property type please remove property type for parameter resource_group_name for cmd network vhub connection show
1008 - ParaPropAdd network vhub connection show cmd network vhub connection show update parameter virtual_hub_name: added property type please remove property type for parameter virtual_hub_name for cmd network vhub connection show
1008 - ParaPropAdd network vhub connection update cmd network vhub connection update update parameter associated_inbound_routemap: added property type please remove property type for parameter associated_inbound_routemap for cmd network vhub connection update
1008 - ParaPropAdd network vhub connection update cmd network vhub connection update update parameter associated_outbound_routemap: added property type please remove property type for parameter associated_outbound_routemap for cmd network vhub connection update
1008 - ParaPropAdd network vhub connection update cmd network vhub connection update update parameter associated_route_table: added property type please remove property type for parameter associated_route_table for cmd network vhub connection update
1008 - ParaPropAdd network vhub connection update cmd network vhub connection update update parameter connection_name: added property type please remove property type for parameter connection_name for cmd network vhub connection update
1008 - ParaPropAdd network vhub connection update cmd network vhub connection update update parameter labels: added property type please remove property type for parameter labels for cmd network vhub connection update
1008 - ParaPropAdd network vhub connection update cmd network vhub connection update update parameter no_wait: added property choices please remove property choices for parameter no_wait for cmd network vhub connection update
1008 - ParaPropAdd network vhub connection update cmd network vhub connection update update parameter no_wait: added property type please remove property type for parameter no_wait for cmd network vhub connection update
1008 - ParaPropAdd network vhub connection update cmd network vhub connection update update parameter propagated_route_tables: added property type please remove property type for parameter propagated_route_tables for cmd network vhub connection update
1008 - ParaPropAdd network vhub connection update cmd network vhub connection update update parameter resource_group_name: added property type please remove property type for parameter resource_group_name for cmd network vhub connection update
1008 - ParaPropAdd network vhub connection update cmd network vhub connection update update parameter virtual_hub_name: added property type please remove property type for parameter virtual_hub_name for cmd network vhub connection update
1008 - ParaPropAdd network vhub connection wait cmd network vhub connection wait update parameter connection_name: added property type please remove property type for parameter connection_name for cmd network vhub connection wait
1008 - ParaPropAdd network vhub connection wait cmd network vhub connection wait update parameter resource_group_name: added property type please remove property type for parameter resource_group_name for cmd network vhub connection wait
1008 - ParaPropAdd network vhub connection wait cmd network vhub connection wait update parameter virtual_hub_name: added property type please remove property type for parameter virtual_hub_name for cmd network vhub connection wait
⚠️ 1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter address_prefixes: added property aaz_type
⚠️ 1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter allow_hub_to_remote_vnet_transit: added property aaz_type
⚠️ 1010 - ParaPropUpdate network vhub connection create cmd network vhub connection create update parameter allow_hub_to_remote_vnet_transit: updated property choices from ['false', 'true'] to ['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes']
⚠️ 1010 - ParaPropUpdate network vhub connection create cmd network vhub connection create update parameter allow_hub_to_remote_vnet_transit: updated property name from allow_hub_to_remote_vnet_transit to remote_vnet_transit
⚠️ 1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter allow_remote_vnet_to_use_hub_vnet_gateways: added property aaz_type
⚠️ 1010 - ParaPropUpdate network vhub connection create cmd network vhub connection create update parameter allow_remote_vnet_to_use_hub_vnet_gateways: updated property choices from ['false', 'true'] to ['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes']
⚠️ 1010 - ParaPropUpdate network vhub connection create cmd network vhub connection create update parameter allow_remote_vnet_to_use_hub_vnet_gateways: updated property name from allow_remote_vnet_to_use_hub_vnet_gateways to use_hub_vnet_gateways
⚠️ 1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter associated_inbound_routemap: added property aaz_type
⚠️ 1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter associated_outbound_routemap: added property aaz_type
⚠️ 1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter associated_route_table: added property aaz_type
⚠️ 1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter connection_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate network vhub connection create cmd network vhub connection create update parameter connection_name: updated property name from connection_name to name
⚠️ 1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter enable_internet_security: added property aaz_default
⚠️ 1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter enable_internet_security: added property aaz_type
⚠️ 1010 - ParaPropUpdate network vhub connection create cmd network vhub connection create update parameter enable_internet_security: updated property choices from ['false', 'true'] to ['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes']
⚠️ 1010 - ParaPropUpdate network vhub connection create cmd network vhub connection create update parameter enable_internet_security: updated property name from enable_internet_security to internet_security
⚠️ 1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter labels: added property aaz_type
⚠️ 1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter next_hop_ip_address: added property aaz_type
⚠️ 1010 - ParaPropUpdate network vhub connection create cmd network vhub connection create update parameter next_hop_ip_address: updated property name from next_hop_ip_address to next_hop
⚠️ 1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter no_wait: added property aaz_type
⚠️ 1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter no_wait: added property nargs
⚠️ 1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter propagated_route_tables: added property aaz_type
⚠️ 1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter remote_virtual_network: added property aaz_type
⚠️ 1010 - ParaPropUpdate network vhub connection create cmd network vhub connection create update parameter remote_virtual_network: updated property name from remote_virtual_network to remote_vnet
⚠️ 1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter resource_group_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate network vhub connection create cmd network vhub connection create update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter route_name: added property aaz_type
⚠️ 1008 - ParaPropAdd network vhub connection create cmd network vhub connection create update parameter virtual_hub_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate network vhub connection create cmd network vhub connection create update parameter virtual_hub_name: updated property name from virtual_hub_name to vhub_name
⚠️ 1004 - CmdPropRemove network vhub connection delete cmd network vhub connection delete removed property confirmation
⚠️ 1008 - ParaPropAdd network vhub connection delete cmd network vhub connection delete update parameter connection_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate network vhub connection delete cmd network vhub connection delete update parameter connection_name: updated property name from connection_name to name
⚠️ 1008 - ParaPropAdd network vhub connection delete cmd network vhub connection delete update parameter no_wait: added property aaz_type
⚠️ 1008 - ParaPropAdd network vhub connection delete cmd network vhub connection delete update parameter no_wait: added property nargs
⚠️ 1008 - ParaPropAdd network vhub connection delete cmd network vhub connection delete update parameter resource_group_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate network vhub connection delete cmd network vhub connection delete update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd network vhub connection delete cmd network vhub connection delete update parameter virtual_hub_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate network vhub connection delete cmd network vhub connection delete update parameter virtual_hub_name: updated property name from virtual_hub_name to vhub_name
⚠️ 1006 - ParaAdd network vhub connection list cmd network vhub connection list added parameter pagination_limit
⚠️ 1006 - ParaAdd network vhub connection list cmd network vhub connection list added parameter pagination_token
⚠️ 1008 - ParaPropAdd network vhub connection list cmd network vhub connection list update parameter resource_group_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate network vhub connection list cmd network vhub connection list update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd network vhub connection list cmd network vhub connection list update parameter virtual_hub_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate network vhub connection list cmd network vhub connection list update parameter virtual_hub_name: updated property name from virtual_hub_name to vhub_name
⚠️ 1008 - ParaPropAdd network vhub connection show cmd network vhub connection show update parameter connection_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate network vhub connection show cmd network vhub connection show update parameter connection_name: updated property name from connection_name to name
⚠️ 1008 - ParaPropAdd network vhub connection show cmd network vhub connection show update parameter resource_group_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate network vhub connection show cmd network vhub connection show update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd network vhub connection show cmd network vhub connection show update parameter virtual_hub_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate network vhub connection show cmd network vhub connection show update parameter virtual_hub_name: updated property name from virtual_hub_name to vhub_name
⚠️ 1008 - ParaPropAdd network vhub connection update cmd network vhub connection update update parameter associated_inbound_routemap: added property aaz_type
⚠️ 1008 - ParaPropAdd network vhub connection update cmd network vhub connection update update parameter associated_outbound_routemap: added property aaz_type
⚠️ 1008 - ParaPropAdd network vhub connection update cmd network vhub connection update update parameter associated_route_table: added property aaz_type
⚠️ 1008 - ParaPropAdd network vhub connection update cmd network vhub connection update update parameter connection_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate network vhub connection update cmd network vhub connection update update parameter connection_name: updated property name from connection_name to name
⚠️ 1008 - ParaPropAdd network vhub connection update cmd network vhub connection update update parameter labels: added property aaz_type
⚠️ 1008 - ParaPropAdd network vhub connection update cmd network vhub connection update update parameter no_wait: added property aaz_type
⚠️ 1008 - ParaPropAdd network vhub connection update cmd network vhub connection update update parameter no_wait: added property nargs
⚠️ 1008 - ParaPropAdd network vhub connection update cmd network vhub connection update update parameter propagated_route_tables: added property aaz_type
⚠️ 1008 - ParaPropAdd network vhub connection update cmd network vhub connection update update parameter properties_to_add: added property aaz_type
⚠️ 1008 - ParaPropAdd network vhub connection update cmd network vhub connection update update parameter properties_to_remove: added property aaz_type
⚠️ 1008 - ParaPropAdd network vhub connection update cmd network vhub connection update update parameter properties_to_set: added property aaz_type
⚠️ 1008 - ParaPropAdd network vhub connection update cmd network vhub connection update update parameter resource_group_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate network vhub connection update cmd network vhub connection update update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd network vhub connection update cmd network vhub connection update update parameter virtual_hub_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate network vhub connection update cmd network vhub connection update update parameter virtual_hub_name: updated property name from virtual_hub_name to vhub_name
⚠️ 1008 - ParaPropAdd network vhub connection wait cmd network vhub connection wait update parameter connection_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate network vhub connection wait cmd network vhub connection wait update parameter connection_name: updated property name from connection_name to name
⚠️ 1008 - ParaPropAdd network vhub connection wait cmd network vhub connection wait update parameter resource_group_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate network vhub connection wait cmd network vhub connection wait update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd network vhub connection wait cmd network vhub connection wait update parameter virtual_hub_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate network vhub connection wait cmd network vhub connection wait update parameter virtual_hub_name: updated property name from virtual_hub_name to vhub_name

@azure-client-tools-bot-prd
Copy link

Hi @necusjz,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 27, 2023

Network

@necusjz necusjz changed the title {Network} az network vhub connection: Fix cross-tenant connection cannot be created [Network] az network vhub connection: Fix cross-tenant connection cannot be created Jul 27, 2023
@necusjz necusjz merged commit d07c3b8 into Azure:main Jul 27, 2023
@necusjz necusjz deleted the migrate-vhub-connection branch July 27, 2023 08:00
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ virtual-wan ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=76710&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Network

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants