Skip to content

[dataprotection] AKS Hooks for backup and restore, time validation fix#6562

Merged
evelyn-ys merged 15 commits intoAzure:mainfrom
zubairabid:users/zubair/akshooks
Aug 14, 2023
Merged

[dataprotection] AKS Hooks for backup and restore, time validation fix#6562
evelyn-ys merged 15 commits intoAzure:mainfrom
zubairabid:users/zubair/akshooks

Conversation

@zubairabid
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az dataprotection

  • Upgraded API version for Backup Instance CRUD operations, Restore Trigger, and Validate and Restore. TODO upgrade API version across the board
  • Implemented backup-hook-refs and restore-hook-refs options for initialize-backupconfig and initialize-restoreconfig respectively
  • Fixed bug with datetime-type validation - it works now instead of appending ".0000000Z" to any string it receives.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Hi @zubairabid,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 26, 2023

⚠️Azure CLI Extensions Breaking Change Test
⚠️dataprotection
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd dataprotection backup-instance initialize-backupconfig cmd dataprotection backup-instance initialize-backupconfig added parameter backup_hook_references
⚠️ 1006 - ParaAdd dataprotection backup-instance initialize-restoreconfig cmd dataprotection backup-instance initialize-restoreconfig added parameter restore_hook_references
⚠️ 1006 - ParaAdd dataprotection backup-instance update cmd dataprotection backup-instance update added parameter identity_details
⚠️ 1001 - CmdAdd dataprotection backup-policy update cmd dataprotection backup-policy update added

@azure-client-tools-bot-prd
Copy link

Hi @zubairabid,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 26, 2023

dataprotection

@zubairabid zubairabid marked this pull request as ready for review August 4, 2023 04:14
Copy link
Member

@evelyn-ys evelyn-ys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for new command/parameter

@evelyn-ys
Copy link
Member

If you want to release a new version, don't forget to update the version in setup.py and history.rst

@zubairabid
Copy link
Contributor Author

If you want to release a new version, don't forget to update the version in setup.py and history.rst

Added tests, and also updated the version.

@evelyn-ys evelyn-ys merged commit 8655f76 into Azure:main Aug 14, 2023
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ dataprotection ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=82058&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants