Skip to content

Conversation

@Greedygre
Copy link
Contributor

@Greedygre Greedygre commented Jul 26, 2023


Refactor az containerapp job show/list/delete/create for containerapp-preview extension.
Similar to commands az containerapp create/show/list/delete refactor.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az containerapp job show/list/delete/create

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 26, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @Greedygre,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link

Hi @Greedygre,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 26, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@Greedygre
Copy link
Contributor Author

Hi @anandanthony
Could you please help to review this PR? Thanks.

@Greedygre
Copy link
Contributor Author

Will rerun all tests for az containerapp job with --live.

@zhoxing-ms zhoxing-ms merged commit 2fb2c29 into Azure:main Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants