Skip to content

[DNC] Update version to 2023-05-18-preview, migrate to use AAZ #6554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kairu-ms merged 8 commits into from
Jul 31, 2023
Merged

[DNC] Update version to 2023-05-18-preview, migrate to use AAZ #6554

kairu-ms merged 8 commits into from
Jul 31, 2023

Conversation

@jackieluc
Copy link
Member

@jackieluc jackieluc commented Jul 25, 2023 •
edited
Loading

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az dnc

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 25, 2023 •
edited
Loading

❌Azure CLI Extensions Breaking Change Test
❌dnc
rule cmd_name rule_message suggest_message
❌ 1010 - ParaPropUpdate dnc controller create cmd dnc controller create update parameter location: updated property type from custom_type to String please change property type from String to custom_type for parameter location of cmd dnc controller create
❌ 1008 - ParaPropAdd dnc controller create cmd dnc controller create update parameter no_wait: added property choices please remove property choices for parameter no_wait for cmd dnc controller create
❌ 1008 - ParaPropAdd dnc controller create cmd dnc controller create update parameter no_wait: added property type please remove property type for parameter no_wait for cmd dnc controller create
❌ 1008 - ParaPropAdd dnc controller create cmd dnc controller create update parameter resource_group_name: added property type please remove property type for parameter resource_group_name for cmd dnc controller create
❌ 1010 - ParaPropUpdate dnc controller create cmd dnc controller create update parameter resource_name: updated property type from str to String please change property type from String to str for parameter resource_name of cmd dnc controller create
❌ 1008 - ParaPropAdd dnc controller create cmd dnc controller create update parameter tags: added property type please remove property type for parameter tags for cmd dnc controller create
❌ 1008 - ParaPropAdd dnc controller delete cmd dnc controller delete update parameter no_wait: added property choices please remove property choices for parameter no_wait for cmd dnc controller delete
❌ 1008 - ParaPropAdd dnc controller delete cmd dnc controller delete update parameter no_wait: added property type please remove property type for parameter no_wait for cmd dnc controller delete
❌ 1008 - ParaPropAdd dnc controller delete cmd dnc controller delete update parameter resource_group_name: added property type please remove property type for parameter resource_group_name for cmd dnc controller delete
❌ 1010 - ParaPropUpdate dnc controller delete cmd dnc controller delete update parameter resource_name: updated property type from str to String please change property type from String to str for parameter resource_name of cmd dnc controller delete
❌ 1008 - ParaPropAdd dnc controller show cmd dnc controller show update parameter resource_group_name: added property type please remove property type for parameter resource_group_name for cmd dnc controller show
❌ 1010 - ParaPropUpdate dnc controller show cmd dnc controller show update parameter resource_name: updated property type from str to String please change property type from String to str for parameter resource_name of cmd dnc controller show
❌ 1008 - ParaPropAdd dnc controller wait cmd dnc controller wait update parameter resource_group_name: added property type please remove property type for parameter resource_group_name for cmd dnc controller wait
❌ 1010 - ParaPropUpdate dnc controller wait cmd dnc controller wait update parameter resource_name: updated property type from str to String please change property type from String to str for parameter resource_name of cmd dnc controller wait
❌ 1010 - ParaPropUpdate dnc delegated-subnet-service create cmd dnc delegated-subnet-service create update parameter id_: updated property type from str to String please change property type from String to str for parameter id_ of cmd dnc delegated-subnet-service create
❌ 1010 - ParaPropUpdate dnc delegated-subnet-service create cmd dnc delegated-subnet-service create update parameter location: updated property type from custom_type to String please change property type from String to custom_type for parameter location of cmd dnc delegated-subnet-service create
❌ 1008 - ParaPropAdd dnc delegated-subnet-service create cmd dnc delegated-subnet-service create update parameter no_wait: added property choices please remove property choices for parameter no_wait for cmd dnc delegated-subnet-service create
❌ 1008 - ParaPropAdd dnc delegated-subnet-service create cmd dnc delegated-subnet-service create update parameter no_wait: added property type please remove property type for parameter no_wait for cmd dnc delegated-subnet-service create
❌ 1008 - ParaPropAdd dnc delegated-subnet-service create cmd dnc delegated-subnet-service create update parameter resource_group_name: added property type please remove property type for parameter resource_group_name for cmd dnc delegated-subnet-service create
❌ 1010 - ParaPropUpdate dnc delegated-subnet-service create cmd dnc delegated-subnet-service create update parameter resource_name: updated property type from str to String please change property type from String to str for parameter resource_name of cmd dnc delegated-subnet-service create
❌ 1010 - ParaPropUpdate dnc delegated-subnet-service create cmd dnc delegated-subnet-service create update parameter subnet_details_id: updated property type from str to String please change property type from String to str for parameter subnet_details_id of cmd dnc delegated-subnet-service create
❌ 1008 - ParaPropAdd dnc delegated-subnet-service create cmd dnc delegated-subnet-service create update parameter tags: added property type please remove property type for parameter tags for cmd dnc delegated-subnet-service create
❌ 1008 - ParaPropAdd dnc delegated-subnet-service delete cmd dnc delegated-subnet-service delete update parameter force_delete: added property type please remove property type for parameter force_delete for cmd dnc delegated-subnet-service delete
❌ 1008 - ParaPropAdd dnc delegated-subnet-service delete cmd dnc delegated-subnet-service delete update parameter no_wait: added property choices please remove property choices for parameter no_wait for cmd dnc delegated-subnet-service delete
❌ 1008 - ParaPropAdd dnc delegated-subnet-service delete cmd dnc delegated-subnet-service delete update parameter no_wait: added property type please remove property type for parameter no_wait for cmd dnc delegated-subnet-service delete
❌ 1008 - ParaPropAdd dnc delegated-subnet-service delete cmd dnc delegated-subnet-service delete update parameter resource_group_name: added property type please remove property type for parameter resource_group_name for cmd dnc delegated-subnet-service delete
❌ 1010 - ParaPropUpdate dnc delegated-subnet-service delete cmd dnc delegated-subnet-service delete update parameter resource_name: updated property type from str to String please change property type from String to str for parameter resource_name of cmd dnc delegated-subnet-service delete
❌ 1008 - ParaPropAdd dnc delegated-subnet-service show cmd dnc delegated-subnet-service show update parameter resource_group_name: added property type please remove property type for parameter resource_group_name for cmd dnc delegated-subnet-service show
❌ 1010 - ParaPropUpdate dnc delegated-subnet-service show cmd dnc delegated-subnet-service show update parameter resource_name: updated property type from str to String please change property type from String to str for parameter resource_name of cmd dnc delegated-subnet-service show
❌ 1008 - ParaPropAdd dnc delegated-subnet-service wait cmd dnc delegated-subnet-service wait update parameter resource_group_name: added property type please remove property type for parameter resource_group_name for cmd dnc delegated-subnet-service wait
❌ 1010 - ParaPropUpdate dnc delegated-subnet-service wait cmd dnc delegated-subnet-service wait update parameter resource_name: updated property type from str to String please change property type from String to str for parameter resource_name of cmd dnc delegated-subnet-service wait
❌ 1010 - ParaPropUpdate dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter api_server_endpoint: updated property type from str to String please change property type from String to str for parameter api_server_endpoint of cmd dnc orchestrator-instance-service create
❌ 1010 - ParaPropUpdate dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter cluster_root_ca: updated property type from str to String please change property type from String to str for parameter cluster_root_ca of cmd dnc orchestrator-instance-service create
❌ 1010 - ParaPropUpdate dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter id_: updated property type from str to String please change property type from String to str for parameter id_ of cmd dnc orchestrator-instance-service create
❌ 1010 - ParaPropUpdate dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter location: updated property type from custom_type to String please change property type from String to custom_type for parameter location of cmd dnc orchestrator-instance-service create
❌ 1008 - ParaPropAdd dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter no_wait: added property choices please remove property choices for parameter no_wait for cmd dnc orchestrator-instance-service create
❌ 1008 - ParaPropAdd dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter no_wait: added property type please remove property type for parameter no_wait for cmd dnc orchestrator-instance-service create
❌ 1010 - ParaPropUpdate dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter orchestrator_app_id: updated property type from str to String please change property type from String to str for parameter orchestrator_app_id of cmd dnc orchestrator-instance-service create
❌ 1010 - ParaPropUpdate dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter orchestrator_tenant_id: updated property type from str to String please change property type from String to str for parameter orchestrator_tenant_id of cmd dnc orchestrator-instance-service create
❌ 1010 - ParaPropUpdate dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter private_link_resource_id: updated property type from str to String please change property type from String to str for parameter private_link_resource_id of cmd dnc orchestrator-instance-service create
❌ 1008 - ParaPropAdd dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter resource_group_name: added property type please remove property type for parameter resource_group_name for cmd dnc orchestrator-instance-service create
❌ 1010 - ParaPropUpdate dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter resource_name: updated property type from str to String please change property type from String to str for parameter resource_name of cmd dnc orchestrator-instance-service create
❌ 1008 - ParaPropAdd dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter tags: added property type please remove property type for parameter tags for cmd dnc orchestrator-instance-service create
❌ 1008 - ParaPropAdd dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter type_: added property type please remove property type for parameter type_ for cmd dnc orchestrator-instance-service create
❌ 1008 - ParaPropAdd dnc orchestrator-instance-service delete cmd dnc orchestrator-instance-service delete update parameter force_delete: added property type please remove property type for parameter force_delete for cmd dnc orchestrator-instance-service delete
❌ 1008 - ParaPropAdd dnc orchestrator-instance-service delete cmd dnc orchestrator-instance-service delete update parameter no_wait: added property choices please remove property choices for parameter no_wait for cmd dnc orchestrator-instance-service delete
❌ 1008 - ParaPropAdd dnc orchestrator-instance-service delete cmd dnc orchestrator-instance-service delete update parameter no_wait: added property type please remove property type for parameter no_wait for cmd dnc orchestrator-instance-service delete
❌ 1008 - ParaPropAdd dnc orchestrator-instance-service delete cmd dnc orchestrator-instance-service delete update parameter resource_group_name: added property type please remove property type for parameter resource_group_name for cmd dnc orchestrator-instance-service delete
❌ 1010 - ParaPropUpdate dnc orchestrator-instance-service delete cmd dnc orchestrator-instance-service delete update parameter resource_name: updated property type from str to String please change property type from String to str for parameter resource_name of cmd dnc orchestrator-instance-service delete
❌ 1008 - ParaPropAdd dnc orchestrator-instance-service show cmd dnc orchestrator-instance-service show update parameter resource_group_name: added property type please remove property type for parameter resource_group_name for cmd dnc orchestrator-instance-service show
❌ 1010 - ParaPropUpdate dnc orchestrator-instance-service show cmd dnc orchestrator-instance-service show update parameter resource_name: updated property type from str to String please change property type from String to str for parameter resource_name of cmd dnc orchestrator-instance-service show
❌ 1008 - ParaPropAdd dnc orchestrator-instance-service wait cmd dnc orchestrator-instance-service wait update parameter resource_group_name: added property type please remove property type for parameter resource_group_name for cmd dnc orchestrator-instance-service wait
❌ 1010 - ParaPropUpdate dnc orchestrator-instance-service wait cmd dnc orchestrator-instance-service wait update parameter resource_name: updated property type from str to String please change property type from String to str for parameter resource_name of cmd dnc orchestrator-instance-service wait
⚠️ 1006 - ParaAdd dnc controller create cmd dnc controller create added parameter purpose
⚠️ 1008 - ParaPropAdd dnc controller create cmd dnc controller create update parameter location: added property aaz_type
⚠️ 1008 - ParaPropAdd dnc controller create cmd dnc controller create update parameter no_wait: added property aaz_type
⚠️ 1008 - ParaPropAdd dnc controller create cmd dnc controller create update parameter no_wait: added property nargs
⚠️ 1008 - ParaPropAdd dnc controller create cmd dnc controller create update parameter resource_group_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc controller create cmd dnc controller create update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd dnc controller create cmd dnc controller create update parameter resource_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc controller create cmd dnc controller create update parameter resource_name: updated property options from ['--resource-name'] to ['--name', '--resource-name', '-n']
⚠️ 1008 - ParaPropAdd dnc controller create cmd dnc controller create update parameter tags: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc controller create cmd dnc controller create update parameter tags: updated property nargs from * to +
⚠️ 1004 - CmdPropRemove dnc controller delete cmd dnc controller delete removed property confirmation
⚠️ 1008 - ParaPropAdd dnc controller delete cmd dnc controller delete update parameter no_wait: added property aaz_type
⚠️ 1008 - ParaPropAdd dnc controller delete cmd dnc controller delete update parameter no_wait: added property nargs
⚠️ 1008 - ParaPropAdd dnc controller delete cmd dnc controller delete update parameter resource_group_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc controller delete cmd dnc controller delete update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd dnc controller delete cmd dnc controller delete update parameter resource_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc controller delete cmd dnc controller delete update parameter resource_name: updated property options from ['--resource-name'] to ['--name', '--resource-name', '-n']
⚠️ 1008 - ParaPropAdd dnc controller show cmd dnc controller show update parameter resource_group_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc controller show cmd dnc controller show update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd dnc controller show cmd dnc controller show update parameter resource_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc controller show cmd dnc controller show update parameter resource_name: updated property options from ['--resource-name'] to ['--name', '--resource-name', '-n']
⚠️ 1008 - ParaPropAdd dnc controller wait cmd dnc controller wait update parameter resource_group_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc controller wait cmd dnc controller wait update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd dnc controller wait cmd dnc controller wait update parameter resource_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc controller wait cmd dnc controller wait update parameter resource_name: updated property options from ['--resource-name'] to ['--name', '--resource-name', '-n']
⚠️ 1008 - ParaPropAdd dnc delegated-subnet-service create cmd dnc delegated-subnet-service create update parameter id_: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc delegated-subnet-service create cmd dnc delegated-subnet-service create update parameter id_: updated property name from id_ to id
⚠️ 1008 - ParaPropAdd dnc delegated-subnet-service create cmd dnc delegated-subnet-service create update parameter location: added property aaz_type
⚠️ 1008 - ParaPropAdd dnc delegated-subnet-service create cmd dnc delegated-subnet-service create update parameter no_wait: added property aaz_type
⚠️ 1008 - ParaPropAdd dnc delegated-subnet-service create cmd dnc delegated-subnet-service create update parameter no_wait: added property nargs
⚠️ 1008 - ParaPropAdd dnc delegated-subnet-service create cmd dnc delegated-subnet-service create update parameter resource_group_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc delegated-subnet-service create cmd dnc delegated-subnet-service create update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd dnc delegated-subnet-service create cmd dnc delegated-subnet-service create update parameter resource_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc delegated-subnet-service create cmd dnc delegated-subnet-service create update parameter resource_name: updated property options from ['--resource-name'] to ['--name', '--resource-name', '-n']
⚠️ 1008 - ParaPropAdd dnc delegated-subnet-service create cmd dnc delegated-subnet-service create update parameter subnet_details_id: added property aaz_type
⚠️ 1008 - ParaPropAdd dnc delegated-subnet-service create cmd dnc delegated-subnet-service create update parameter tags: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc delegated-subnet-service create cmd dnc delegated-subnet-service create update parameter tags: updated property nargs from * to +
⚠️ 1004 - CmdPropRemove dnc delegated-subnet-service delete cmd dnc delegated-subnet-service delete removed property confirmation
⚠️ 1008 - ParaPropAdd dnc delegated-subnet-service delete cmd dnc delegated-subnet-service delete update parameter force_delete: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc delegated-subnet-service delete cmd dnc delegated-subnet-service delete update parameter force_delete: updated property choices from ['false', 'true'] to ['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes']
⚠️ 1008 - ParaPropAdd dnc delegated-subnet-service delete cmd dnc delegated-subnet-service delete update parameter no_wait: added property aaz_type
⚠️ 1008 - ParaPropAdd dnc delegated-subnet-service delete cmd dnc delegated-subnet-service delete update parameter no_wait: added property nargs
⚠️ 1008 - ParaPropAdd dnc delegated-subnet-service delete cmd dnc delegated-subnet-service delete update parameter resource_group_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc delegated-subnet-service delete cmd dnc delegated-subnet-service delete update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd dnc delegated-subnet-service delete cmd dnc delegated-subnet-service delete update parameter resource_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc delegated-subnet-service delete cmd dnc delegated-subnet-service delete update parameter resource_name: updated property options from ['--resource-name'] to ['--name', '--resource-name', '-n']
⚠️ 1008 - ParaPropAdd dnc delegated-subnet-service show cmd dnc delegated-subnet-service show update parameter resource_group_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc delegated-subnet-service show cmd dnc delegated-subnet-service show update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd dnc delegated-subnet-service show cmd dnc delegated-subnet-service show update parameter resource_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc delegated-subnet-service show cmd dnc delegated-subnet-service show update parameter resource_name: updated property options from ['--resource-name'] to ['--name', '--resource-name', '-n']
⚠️ 1008 - ParaPropAdd dnc delegated-subnet-service wait cmd dnc delegated-subnet-service wait update parameter resource_group_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc delegated-subnet-service wait cmd dnc delegated-subnet-service wait update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd dnc delegated-subnet-service wait cmd dnc delegated-subnet-service wait update parameter resource_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc delegated-subnet-service wait cmd dnc delegated-subnet-service wait update parameter resource_name: updated property options from ['--resource-name'] to ['--name', '--resource-name', '-n']
⚠️ 1006 - ParaAdd dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create added parameter kind
⚠️ 1008 - ParaPropAdd dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter api_server_endpoint: added property aaz_type
⚠️ 1008 - ParaPropAdd dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter cluster_root_ca: added property aaz_type
⚠️ 1008 - ParaPropAdd dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter id_: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter id_: updated property name from id_ to id
⚠️ 1008 - ParaPropAdd dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter location: added property aaz_type
⚠️ 1008 - ParaPropAdd dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter no_wait: added property aaz_type
⚠️ 1008 - ParaPropAdd dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter no_wait: added property nargs
⚠️ 1008 - ParaPropAdd dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter orchestrator_app_id: added property aaz_type
⚠️ 1008 - ParaPropAdd dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter orchestrator_tenant_id: added property aaz_type
⚠️ 1008 - ParaPropAdd dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter private_link_resource_id: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter private_link_resource_id: updated property name from private_link_resource_id to priv_link_resource_id
⚠️ 1008 - ParaPropAdd dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter resource_group_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter resource_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter resource_name: updated property options from ['--resource-name'] to ['--name', '--resource-name', '-n']
⚠️ 1008 - ParaPropAdd dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter tags: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter tags: updated property nargs from * to +
⚠️ 1008 - ParaPropAdd dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter type_: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc orchestrator-instance-service create cmd dnc orchestrator-instance-service create update parameter type_: updated property name from type_ to type
⚠️ 1004 - CmdPropRemove dnc orchestrator-instance-service delete cmd dnc orchestrator-instance-service delete removed property confirmation
⚠️ 1008 - ParaPropAdd dnc orchestrator-instance-service delete cmd dnc orchestrator-instance-service delete update parameter force_delete: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc orchestrator-instance-service delete cmd dnc orchestrator-instance-service delete update parameter force_delete: updated property choices from ['false', 'true'] to ['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes']
⚠️ 1008 - ParaPropAdd dnc orchestrator-instance-service delete cmd dnc orchestrator-instance-service delete update parameter no_wait: added property aaz_type
⚠️ 1008 - ParaPropAdd dnc orchestrator-instance-service delete cmd dnc orchestrator-instance-service delete update parameter no_wait: added property nargs
⚠️ 1008 - ParaPropAdd dnc orchestrator-instance-service delete cmd dnc orchestrator-instance-service delete update parameter resource_group_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc orchestrator-instance-service delete cmd dnc orchestrator-instance-service delete update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd dnc orchestrator-instance-service delete cmd dnc orchestrator-instance-service delete update parameter resource_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc orchestrator-instance-service delete cmd dnc orchestrator-instance-service delete update parameter resource_name: updated property options from ['--resource-name'] to ['--name', '--resource-name', '-n']
⚠️ 1008 - ParaPropAdd dnc orchestrator-instance-service show cmd dnc orchestrator-instance-service show update parameter resource_group_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc orchestrator-instance-service show cmd dnc orchestrator-instance-service show update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd dnc orchestrator-instance-service show cmd dnc orchestrator-instance-service show update parameter resource_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc orchestrator-instance-service show cmd dnc orchestrator-instance-service show update parameter resource_name: updated property options from ['--resource-name'] to ['--name', '--resource-name', '-n']
⚠️ 1008 - ParaPropAdd dnc orchestrator-instance-service wait cmd dnc orchestrator-instance-service wait update parameter resource_group_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc orchestrator-instance-service wait cmd dnc orchestrator-instance-service wait update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd dnc orchestrator-instance-service wait cmd dnc orchestrator-instance-service wait update parameter resource_name: added property aaz_type
⚠️ 1010 - ParaPropUpdate dnc orchestrator-instance-service wait cmd dnc orchestrator-instance-service wait update parameter resource_name: updated property options from ['--resource-name'] to ['--name', '--resource-name', '-n']

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 25, 2023

Hi @jackieluc,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 25, 2023

Hi @jackieluc,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 25, 2023

DNC

@jackieluc jackieluc changed the title [DNC] Update version to 2023-05-18-preview [DNC] Update version to 2023-05-18-preview, migrate to use AAZ Jul 25, 2023
@yonzhan yonzhan requested review from jsntcy and kairu-ms July 25, 2023 23:04
@AllyW AllyW mentioned this pull request Jul 26, 2023
Open
@AllyW
Copy link
Contributor

AllyW commented Jul 26, 2023 •
edited
Loading

❌Azure CLI Extensions Breaking Change Test

Lost confirmation for aaz cmd. Logged in Azure/azure-cli-dev-tools#414

thomasricci
thomasricci reviewed Jul 26, 2023
View reviewed changes
@jackieluc
Copy link
Member Author

jackieluc commented Jul 26, 2023

@kairu-ms @jsntcy - Looks like the PR automation identified breaking changes. Are there any blockers to this PR from your perspectives that prevents merging? For some additional context, the dnc extension is migrating to use AAZ command models.

Also, what is the expected timeline for reviewing and merging changes like this?

@kairu-ms
Copy link
Contributor

kairu-ms commented Jul 27, 2023

@kairu-ms @jsntcy - Looks like the PR automation identified breaking changes. Are there any blockers to this PR from your perspectives that prevents merging? For some additional context, the dnc extension is migrating to use AAZ command models.

Also, what is the expected timeline for reviewing and merging changes like this?

There's no real breaking change in your PR. We will filter out some meaningless messages.

@jackieluc
Copy link
Member Author

jackieluc commented Jul 27, 2023

@kairu-ms @jsntcy - Looks like the PR automation identified breaking changes. Are there any blockers to this PR from your perspectives that prevents merging? For some additional context, the dnc extension is migrating to use AAZ command models.
Also, what is the expected timeline for reviewing and merging changes like this?

There's no real breaking change in your PR. We will filter out some meaningless messages.

Thanks @kairu-ms, what is the timeline for something like this to merge? Can you clarify what the milestone means? Is that the target date for this to merge?

@kairu-ms
Copy link
Contributor

kairu-ms commented Jul 28, 2023

@kairu-ms @jsntcy - Looks like the PR automation identified breaking changes. Are there any blockers to this PR from your perspectives that prevents merging? For some additional context, the dnc extension is migrating to use AAZ command models.
Also, what is the expected timeline for reviewing and merging changes like this?

There's no real breaking change in your PR. We will filter out some meaningless messages.

Thanks @kairu-ms, what is the timeline for something like this to merge? Can you clarify what the milestone means? Is that the target date for this to merge?

I can merge it anytime. Please fix the CI issues.

@jackieluc
Copy link
Member Author

jackieluc commented Jul 28, 2023

@kairu-ms @jsntcy - Looks like the PR automation identified breaking changes. Are there any blockers to this PR from your perspectives that prevents merging? For some additional context, the dnc extension is migrating to use AAZ command models.
Also, what is the expected timeline for reviewing and merging changes like this?

There's no real breaking change in your PR. We will filter out some meaningless messages.

Thanks @kairu-ms, what is the timeline for something like this to merge? Can you clarify what the milestone means? Is that the target date for this to merge?

I can merge it anytime. Please fix the CI issues.

Thanks @kairu-ms, the CI is green now. Please merge if there's no other concerns on your end.

@kairu-ms kairu-ms merged commit 1cb8314 into Azure:main Jul 31, 2023
@azclibot
Copy link
Collaborator

azclibot commented Jul 31, 2023

[Release] Update index.json for extension [ dnc ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=77523&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kairu-ms kairu-ms kairu-ms approved these changes

@jsntcy jsntcy Awaiting requested review from jsntcy

+1 more reviewer

@thomasricci thomasricci thomasricci approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kairu-ms kairu-ms

Labels

None yet

Projects

None yet

Milestone

August 2023 (2023-09-05)

Development

Successfully merging this pull request may close these issues.

6 participants

@jackieluc @yonzhan @AllyW @kairu-ms @azclibot @thomasricci