Skip to content

Conversation

@rahulm-msft
Copy link
Contributor

@rahulm-msft rahulm-msft commented Jul 25, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Group
    az networkfabric : Manage Azure Network Fabric Management Service API.

Subgroups:
    controller          : Manage Network Fabric Controller Resource.
    device              : Manage Network Device Resource.
    externalnetwork     : Manage External Network Resource.
    fabric              : Manage Network Fabric Resource.
    interface           : Manage Network Interface Resource.
    internalnetwork     : Manage Internal Network Resource.
    internetgateway     : Manage Internet Gateway Resource.
    internetgatewayrule : Manage Internet Gateway Rule Resource.
    ipcommunity         : Manage Ip Community Resource.
    ipextendedcommunity : Manage Ip Extended Community Resource.
    ipprefix            : Manage Ip Prefix Resource.
    l2domain            : Manage L2 Isolation Domain Resource.
    l3domain            : Manage L3 Isolation Domain Resource.
    nni                 : Manage Network To Network Interconnect Resource.
    npb                 : Manage Network Packet Broker Resource.
    rack                : Manage Network Rack Resource.
    routepolicy         : Manage Route Policy Resource.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@rahulm-msft rahulm-msft requested a review from kairu-ms as a code owner July 25, 2023 13:13
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 25, 2023

❌Azure CLI Extensions Breaking Change Test
❌managednetworkfabric
rule cmd_name rule_message suggest_message
1008 - ParaPropAdd networkfabric fabric create cmd networkfabric fabric create update parameter fabric_asn: added property required please remove property required for parameter fabric_asn for cmd networkfabric fabric create
1008 - ParaPropAdd networkfabric fabric create cmd networkfabric fabric create update parameter ipv4_prefix: added property required please remove property required for parameter ipv4_prefix for cmd networkfabric fabric create
1008 - ParaPropAdd networkfabric fabric create cmd networkfabric fabric create update parameter managed_network_config: added property required please remove property required for parameter managed_network_config for cmd networkfabric fabric create
1008 - ParaPropAdd networkfabric fabric create cmd networkfabric fabric create update parameter nf_sku: added property required please remove property required for parameter nf_sku for cmd networkfabric fabric create
1008 - ParaPropAdd networkfabric fabric create cmd networkfabric fabric create update parameter nfc_id: added property required please remove property required for parameter nfc_id for cmd networkfabric fabric create
1008 - ParaPropAdd networkfabric fabric create cmd networkfabric fabric create update parameter server_count_per_rack: added property required please remove property required for parameter server_count_per_rack for cmd networkfabric fabric create
1008 - ParaPropAdd networkfabric fabric create cmd networkfabric fabric create update parameter ts_config: added property required please remove property required for parameter ts_config for cmd networkfabric fabric create
1006 - ParaAdd networkfabric ipcommunity create cmd networkfabric ipcommunity create added parameter ip_community_rules please remove parameter ip_community_rules for cmd networkfabric ipcommunity create
1007 - ParaRemove networkfabric ipcommunity create cmd networkfabric ipcommunity create removed parameter action please add back parameter action for cmd networkfabric ipcommunity create
1007 - ParaRemove networkfabric ipcommunity create cmd networkfabric ipcommunity create removed parameter community_members please add back parameter community_members for cmd networkfabric ipcommunity create
1007 - ParaRemove networkfabric ipcommunity create cmd networkfabric ipcommunity create removed parameter well_known_communities please add back parameter well_known_communities for cmd networkfabric ipcommunity create
1006 - ParaAdd networkfabric ipextendedcommunity create cmd networkfabric ipextendedcommunity create added parameter ip_extended_community_rules please remove parameter ip_extended_community_rules for cmd networkfabric ipextendedcommunity create
1007 - ParaRemove networkfabric ipextendedcommunity create cmd networkfabric ipextendedcommunity create removed parameter action please add back parameter action for cmd networkfabric ipextendedcommunity create
1007 - ParaRemove networkfabric ipextendedcommunity create cmd networkfabric ipextendedcommunity create removed parameter route_targets please add back parameter route_targets for cmd networkfabric ipextendedcommunity create
1008 - ParaPropAdd networkfabric l2domain create cmd networkfabric l2domain create update parameter nf_id: added property required please remove property required for parameter nf_id for cmd networkfabric l2domain create
1008 - ParaPropAdd networkfabric l2domain create cmd networkfabric l2domain create update parameter vlan_id: added property required please remove property required for parameter vlan_id for cmd networkfabric l2domain create
1007 - ParaRemove networkfabric l3domain create cmd networkfabric l3domain create removed parameter description please add back parameter description for cmd networkfabric l3domain create
1008 - ParaPropAdd networkfabric l3domain create cmd networkfabric l3domain create update parameter nf_id: added property required please remove property required for parameter nf_id for cmd networkfabric l3domain create
1007 - ParaRemove networkfabric nni create cmd networkfabric nni create removed parameter layer3_configuration please add back parameter layer3_configuration for cmd networkfabric nni create
1008 - ParaPropAdd networkfabric nni create cmd networkfabric nni create update parameter use_option_b: added property required please remove property required for parameter use_option_b for cmd networkfabric nni create
1006 - ParaAdd networkfabric routepolicy create cmd networkfabric routepolicy create added parameter nf_id please remove parameter nf_id for cmd networkfabric routepolicy create
⚠️ 1006 - ParaAdd networkfabric controller create cmd networkfabric controller create added parameter is_workload_management_network_enabled
⚠️ 1006 - ParaAdd networkfabric controller create cmd networkfabric controller create added parameter nfc_sku
⚠️ 1001 - CmdAdd networkfabric controller update cmd networkfabric controller update added
⚠️ 1006 - ParaAdd networkfabric externalnetwork create cmd networkfabric externalnetwork create added parameter export_route_policy
⚠️ 1006 - ParaAdd networkfabric externalnetwork create cmd networkfabric externalnetwork create added parameter import_route_policy
⚠️ 1010 - ParaPropUpdate networkfabric externalnetwork create cmd networkfabric externalnetwork create update parameter export_route_policy_id: updated property aaz_type from AAZStrArg to AAZResourceIdArg
⚠️ 1010 - ParaPropUpdate networkfabric externalnetwork create cmd networkfabric externalnetwork create update parameter import_route_policy_id: updated property aaz_type from AAZStrArg to AAZResourceIdArg
⚠️ 1001 - CmdAdd networkfabric externalnetwork update cmd networkfabric externalnetwork update added
⚠️ 1010 - ParaPropUpdate networkfabric fabric create cmd networkfabric fabric create update parameter nfc_id: updated property aaz_type from AAZStrArg to AAZResourceIdArg
⚠️ 1001 - CmdAdd networkfabric fabric update cmd networkfabric fabric update added
⚠️ 1006 - ParaAdd networkfabric internalnetwork create cmd networkfabric internalnetwork create added parameter egress_acl_id
⚠️ 1006 - ParaAdd networkfabric internalnetwork create cmd networkfabric internalnetwork create added parameter export_route_policy
⚠️ 1006 - ParaAdd networkfabric internalnetwork create cmd networkfabric internalnetwork create added parameter extension
⚠️ 1006 - ParaAdd networkfabric internalnetwork create cmd networkfabric internalnetwork create added parameter import_route_policy
⚠️ 1006 - ParaAdd networkfabric internalnetwork create cmd networkfabric internalnetwork create added parameter ingress_acl_id
⚠️ 1006 - ParaAdd networkfabric internalnetwork create cmd networkfabric internalnetwork create added parameter is_monitoring_enabled
⚠️ 1010 - ParaPropUpdate networkfabric internalnetwork create cmd networkfabric internalnetwork create update parameter export_route_policy_id: updated property aaz_type from AAZStrArg to AAZResourceIdArg
⚠️ 1010 - ParaPropUpdate networkfabric internalnetwork create cmd networkfabric internalnetwork create update parameter import_route_policy_id: updated property aaz_type from AAZStrArg to AAZResourceIdArg
⚠️ 1001 - CmdAdd networkfabric internalnetwork update cmd networkfabric internalnetwork update added
⚠️ 1011 - SubgroupAdd networkfabric internetgateway sub group networkfabric internetgateway added
⚠️ 1011 - SubgroupAdd networkfabric internetgatewayrule sub group networkfabric internetgatewayrule added
⚠️ 1010 - ParaPropUpdate networkfabric l2domain create cmd networkfabric l2domain create update parameter nf_id: updated property aaz_type from AAZStrArg to AAZResourceIdArg
⚠️ 1001 - CmdAdd networkfabric l2domain update cmd networkfabric l2domain update added
⚠️ 1010 - ParaPropUpdate networkfabric l3domain create cmd networkfabric l3domain create update parameter nf_id: updated property aaz_type from AAZStrArg to AAZResourceIdArg
⚠️ 1001 - CmdAdd networkfabric l3domain update cmd networkfabric l3domain update added
⚠️ 1006 - ParaAdd networkfabric nni create cmd networkfabric nni create added parameter egress_acl_id
⚠️ 1006 - ParaAdd networkfabric nni create cmd networkfabric nni create added parameter export_route_policy
⚠️ 1006 - ParaAdd networkfabric nni create cmd networkfabric nni create added parameter import_route_policy
⚠️ 1006 - ParaAdd networkfabric nni create cmd networkfabric nni create added parameter ingress_acl_id
⚠️ 1006 - ParaAdd networkfabric nni create cmd networkfabric nni create added parameter npb_static_route_configuration
⚠️ 1006 - ParaAdd networkfabric nni create cmd networkfabric nni create added parameter option_b_layer3_configuration
⚠️ 1001 - CmdAdd networkfabric nni update cmd networkfabric nni update added
⚠️ 1011 - SubgroupAdd networkfabric npb sub group networkfabric npb added
⚠️ 1006 - ParaAdd networkfabric routepolicy create cmd networkfabric routepolicy create added parameter address_family_type

@azure-client-tools-bot-prd
Copy link

Hi @rahulm-msft,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link

Hi @rahulm-msft,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 25, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link
Contributor

@kairu-ms kairu-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please added the missing tests for GA release.

Copy link
Contributor

@kairu-ms kairu-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kairu-ms kairu-ms merged commit 2d6d95b into Azure:main Jul 31, 2023
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ managednetworkfabric ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=77579&view=results

@rahulm-msft rahulm-msft deleted the rahul-msft/GA_CLI_Extension branch August 1, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants