{Notification-hub} Migrate notification-hub to AAZ #6551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @Jing-song, |
|
Hi @Jing-song, |
Collaborator
|
Notification-hub |
Contributor
|
|
Contributor
|
Please verify the old command needs confirm or not |
Contributor
|
|
Contributor
|
|
Contributor
|
|
Contributor
|
|
Contributor
|
Please verify the following option names are not changed |
Contributor
Author
|
kairu-ms
reviewed
Jul 26, 2023
Comment on lines
+32
to
+38
| from azext_notification_hub.custom import BaiduUpdate, ApnsUpdate, MpnsUpdate, AdmUpdate, WnsUpdate, GcmUpdate | ||
| self.command_table['notification-hub credential gcm update'] = GcmUpdate(loader=self) | ||
| self.command_table['notification-hub credential adm update'] = AdmUpdate(loader=self) | ||
| self.command_table['notification-hub credential apns update'] = ApnsUpdate(loader=self) | ||
| self.command_table['notification-hub credential wns update'] = WnsUpdate(loader=self) | ||
| self.command_table['notification-hub credential mpns update'] = MpnsUpdate(loader=self) | ||
| self.command_table['notification-hub credential baidu update'] = BaiduUpdate(loader=self) |
Contributor
There was a problem hiding this comment.
Why not use the aaz generated update command directly?
kairu-ms
reviewed
Jul 26, 2023
kairu-ms
reviewed
Jul 26, 2023
kairu-ms
reviewed
Jul 26, 2023
kairu-ms
reviewed
Jul 26, 2023
kairu-ms
approved these changes
Jul 27, 2023
Collaborator
|
[Release] Update index.json for extension [ notification-hub ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=76594&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az notification-hub
AAZ model: Azure/aaz#243
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.