Skip to content

Conversation

@ahmelsayed
Copy link
Contributor

@ahmelsayed ahmelsayed commented Jul 24, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 24, 2023

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1011 - SubgroupAdd containerapp service mariadb sub group containerapp service mariadb added

@azure-client-tools-bot-prd
Copy link

Hi @ahmelsayed,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@azure-client-tools-bot-prd
Copy link

Hi @ahmelsayed,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 24, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link
Contributor

@anandanthony anandanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this would require a new version to be released, can we update the History.rst file with the changes.

@zhoxing-ms
Copy link
Contributor

Please take a look at this comment #6550 (comment)

@ahmelsayed
Copy link
Contributor Author

Please take a look at this comment #6550 (comment)

Done

@zhoxing-ms zhoxing-ms merged commit c7fdae3 into Azure:main Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants