Skip to content

{Interactive} Fix KeyError when entering param not in sample in scenario mode #6541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReaNAiveD merged 5 commits into from
Aug 1, 2023
Merged

{Interactive} Fix KeyError when entering param not in sample in scenario mode #6541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e4c2cb8
Fix error when enter short param in scenario mode
ReaNAiveD Jul 21, 2023
4c07b5c
Fix error when enter short param in scenario mode
ReaNAiveD Jul 21, 2023
fb9385b
Update HISTORY.rst
ReaNAiveD Jul 21, 2023
d0b462d
Merge branch 'main' into fix_short_parma_in_scenario_mode
ReaNAiveD Aug 1, 2023
4d26012
Release New Version
ReaNAiveD Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/interactive/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@
Release History
===============

upcoming
0.5.2
+++++
* Fix Scenario Idx out of bound when selecting recommended scenario
* Add command skipped message in Scenario Execution Mode
* Fix Scenario Idx out of bound when selecting recommended scenario
* Fix `KeyError` when entering param not in sample in scenario mode

0.5.1
+++++
Expand Down
2 changes: 1 addition & 1 deletion src/interactive/azext_interactive/azclishell/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
# Licensed under the MIT License. See License.txt in the project root for license information.
# --------------------------------------------------------------------------------------------

VERSION = '0.5.1'
VERSION = '0.5.2'
3 changes: 2 additions & 1 deletion src/interactive/azext_interactive/azclishell/scenario_suggest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
# --------------------------------------------------------------------------------------------

import re
from collections import defaultdict

from prompt_toolkit.auto_suggest import AutoSuggest, Suggestion

Expand Down Expand Up @@ -31,7 +32,7 @@ def update(self, sample: str):
# The sample should not start with 'az '
self.cur_sample = sample.split('az ')[-1]
# Find parameters used in sample and its value
self.param_sample_value_map = {}
self.param_sample_value_map = defaultdict(lambda: None)
# Find the command part of sample
self.cur_command = self.cur_sample.split('-')[0].strip()
cur_param = ''
Expand Down