Skip to content

{AzureContainerApp} az containerapp create --bind "my-app" throws error when service has dashes in the name "-" #6530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
navba-MSFT wants to merge 5 commits into from
Closed

{AzureContainerApp} az containerapp create --bind "my-app" throws error when service has dashes in the name "-" #6530

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
12b67bb
Update _utils.py
navba-MSFT Jul 19, 2023
4c42230
Update HISTORY.rst
navba-MSFT Jul 19, 2023
4cec3a3
Update setup.py
navba-MSFT Jul 19, 2023
a7578e3
Update HISTORY.rst
navba-MSFT Jul 20, 2023
225db43
Update setup.py
navba-MSFT Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/containerapp/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

Release History
===============
0.3.37
Comment thread
navba-MSFT marked this conversation as resolved.
Outdated
Comment thread
navba-MSFT marked this conversation as resolved.
Outdated
++++++
* 'az containerapp create': fix `InvalidArgumentValueError` exception when binding has `-` dash in its name.

0.3.36
++++++
* 'az containerapp hostname bind': fix exception when not bringing --validation-method inputs
Expand Down
2 changes: 1 addition & 1 deletion src/containerapp/azext_containerapp/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ def process_service(cmd, resource_list, service_name, arg_dict, subscription_id,


def validate_binding_name(binding_name):
pattern = r'^(?=.{1,60}$)[a-zA-Z0-9._]+$'
pattern = r'^(?=.{1,60}$)[a-zA-Z0-9._-]+$'

@Greedygre Greedygre Jul 20, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a message for this validate_binding_name, I'm not sure this binding name is available if it contains -

raise InvalidArgumentValueError("The Binding Name can only contain letters, numbers (0-9), periods ('.'), "
                                            "and underscores ('_'). The length must not be more than 60 characters.")

@Greedygre Greedygre Jul 20, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yash-nisar Do you know whether the binding name can contains - ?

return bool(re.match(pattern, binding_name))


Expand Down
2 changes: 1 addition & 1 deletion src/containerapp/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
# TODO: Confirm this is the right version number you want and it matches your
# HISTORY.rst entry.

VERSION = '0.3.36'
VERSION = '0.3.37'
Comment thread
navba-MSFT marked this conversation as resolved.
Outdated

# The full list of classifiers is available at
# https://pypi.python.org/pypi?%3Aaction=list_classifiers
Expand Down