-
Notifications
You must be signed in to change notification settings - Fork 1.5k
containerapp refactor client #6501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @Greedygre, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
b72ee3e to
00b7b8c
Compare
|
hi @zhoxing-ms The root error msg is as following. The containerapp-preview's command can't run independently. Need to install containerapp extension. |
157858e to
db99bfc
Compare
| run(cmd, check=True) | ||
|
|
||
| def tearDown(self): | ||
| cmd = ['azdev', 'extension', 'remove', 'containerapp'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make concurrent execution of tests more stable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This CI test failed Pipelines - Run 20230712.36 logs (azure.com)
only python 3.10 tests failed. And Error as following.
[gw0] [ 50%] FAILED src/containerapp-preview/azext_containerapp_preview/tests/latest/test_containerapp_preview_scenario.py::ContainerappScenarioTest::test_containerapp_preview_e2e
src/containerapp-preview/azext_containerapp_preview/tests/latest/test_containerapp_preview_scenario.py::ContainerappScenarioTest::test_containerapp_preview_environment_type
[gw0] [100%] PASSED src/containerapp-preview/azext_containerapp_preview/tests/latest/test_containerapp_preview_scenario.py::ContainerappScenarioTest::test_containerapp_preview_environment_type
ERROR cli.azure.cli.core.azclierror:azlogging.py:212 unrecognized arguments: --environment-type managed
ERROR az_command_data_logger:azlogging.py:213 unrecognized arguments: --environment-type managed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And with more and more test cases( with different file), this kind of azdev extension add containerapp in a case will be unstable
Juliehzl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with suggestions for tearDown
|
Hi @zhoxing-ms BTW: If there is a better way to install dependency |
This checklist is used to make sure that common guidelines for a pull request are followed.
Refactor clients for separating GA and preview extension.
For containerapp extension, use
CURRENT_API_VERSIONto control version.For containerapp-preview extension, use
PREVIEW_API_VERSION. The command in containerapp-preview will overwrite the command in containerapp, and api-version value isPREVIEW_API_VERSION. #6419Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.