Skip to content

Conversation

@priyamshet
Copy link
Member

@priyamshet priyamshet commented Jul 10, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 10, 2023

⚠️Azure CLI Extensions Breaking Change Test
⚠️networkcloud
rule cmd_name rule_message suggest_message
⚠️ 1001 - CmdAdd networkcloud kubernetescluster restart-node cmd networkcloud kubernetescluster restart-node added

@azure-client-tools-bot-prd
Copy link

Hi @priyamshet,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 10, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@yonzhan yonzhan requested review from jsntcy, kairu-ms and necusjz July 10, 2023 23:16
@priyamshet priyamshet changed the title NetworkCloud Azure-cli-extension 2023-07-01 api -Do not Review/Merge 7/15 NetworkCloud Azure-cli-extension 2023-07-01 API Jul 17, 2023
@priyamshet priyamshet marked this pull request as ready for review July 17, 2023 13:37
@priyamshet
Copy link
Member Author

Thanks for the review @kairu-ms , We would like to get these merged on 7/27.

@kairu-ms
Copy link
Contributor

Thanks for the review @kairu-ms , We would like to get these merged on 7/27.

Hi @priyamshet, is it ready to release?

@priyamshet
Copy link
Member Author

priyamshet commented Jul 27, 2023

@kairu-ms , yes please, this is ready to be released. Thank you for your help and following up closely on this.

@kairu-ms kairu-ms merged commit e0d8449 into Azure:main Jul 27, 2023
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ networkcloud ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=76908&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants