Skip to content

Conversation

@wangzelin007
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Hi @wangzelin007,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@ghost ghost added Auto-Assign Auto assign by bot CI labels Jul 5, 2023
@yonzhan
Copy link
Collaborator

yonzhan commented Jul 5, 2023

CI

@ghost ghost requested review from bebound, jiasli, jsntcy, kairu-ms and yonzhan July 5, 2023 03:43
@ghost ghost assigned wangzelin007 Jul 5, 2023
@wangzelin007 wangzelin007 marked this pull request as ready for review July 5, 2023 04:11
@wangzelin007 wangzelin007 merged commit 2c30c07 into Azure:main Jul 5, 2023
Comment on lines +47 to +48
if extension_name != 'partnercenter':
ALL_TESTS.append((extension_name, chosen['downloadUrl'], chosen['filename']))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gives better readability:

Suggested change
if extension_name != 'partnercenter':
ALL_TESTS.append((extension_name, chosen['downloadUrl'], chosen['filename']))
if extension_name == 'partnercenter':
continue
ALL_TESTS.append((extension_name, chosen['downloadUrl'], chosen['filename']))

wangzelin007 added a commit that referenced this pull request Jul 12, 2023
…nsion in IndexRefDocVerify (#6474)"

This reverts commit 2c30c07.
wangzelin007 added a commit that referenced this pull request Jul 12, 2023
…nsion in IndexRefDocVerify (#6474)" (#6508)

This reverts commit 2c30c07.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants