Skip to content

Conversation

@SrinikhilReddy
Copy link
Contributor

@SrinikhilReddy SrinikhilReddy commented Jun 30, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Hi @SrinikhilReddy,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@azure-client-tools-bot-prd
Copy link

Hi @SrinikhilReddy,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@ghost ghost added CosmosDB Auto-Assign Auto assign by bot labels Jun 30, 2023
@ghost ghost requested a review from evelyn-ys June 30, 2023 15:38
@yonzhan
Copy link
Collaborator

yonzhan commented Jun 30, 2023

CosmosDB

@ghost ghost requested review from calvinhzy and yonzhan June 30, 2023 15:38
@ghost ghost assigned evelyn-ys Jun 30, 2023
@SrinikhilReddy SrinikhilReddy marked this pull request as ready for review July 6, 2023 23:38
@evelyn-ys
Copy link
Member

Please make sure all CI checks can pass

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 12, 2023

⚠️Azure CLI Extensions Breaking Change Test
⚠️cosmosdb-preview
rule cmd_name rule_message suggest_message
⚠️ 1001 - CmdAdd cosmosdb mongodb database merge cmd cosmosdb mongodb database merge added
⚠️ 1001 - CmdAdd cosmosdb sql container create cmd cosmosdb sql container create added
⚠️ 1001 - CmdAdd cosmosdb sql container update cmd cosmosdb sql container update added
⚠️ 1001 - CmdAdd cosmosdb sql database merge cmd cosmosdb sql database merge added

@SrinikhilReddy
Copy link
Contributor Author

Please make sure all CI checks can pass

All gates passing please rereview

Copy link
Member

@evelyn-ys evelyn-ys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shows like you delete all _param.py, commands.py and custom.py and recreate again......

It's really hard to review what you actually changed

@SrinikhilReddy
Copy link
Contributor Author

SrinikhilReddy commented Jul 26, 2023

It shows like you delete all _param.py, commands.py and custom.py and recreate again......

It's really hard to review what you actually changed

image

Hi @evelyn-ys @yonzhan @calvinhzy .. Using this option ignores the white space changes... please re-review.

@SrinikhilReddy SrinikhilReddy requested a review from evelyn-ys July 26, 2023 21:22
Copy link
Member

@evelyn-ys evelyn-ys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to release a new version, pls update the version in setup.py and histroy.rst

@SrinikhilReddy SrinikhilReddy requested a review from evelyn-ys July 28, 2023 04:39
@evelyn-ys evelyn-ys merged commit f1bb89b into Azure:main Jul 28, 2023
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ cosmosdb-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=77130&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot CosmosDB

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants