-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Resolve error when fetching Container App workflow name with 'up' command #6428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve error when fetching Container App workflow name with 'up' command #6428
Conversation
|
Hi @cormacpayne, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
Could you please add test case for this PR change |
…into corm/capps-fix-workflow-poll # Conflicts: # src/containerapp/HISTORY.rst
|
@zhoxing-ms -- Hey Xing, for this specific flow that we're fixing, it relies on creating a workflow YAML file in a user's GitHub repository that then triggers a GitHub Action run. Creating a test for this would be tricky when it comes to maintaining the repository that the workflow is created in, managing the secrets to push to this repository, etc. Is there another route we can take for testing this flow that you have any guidance on? Thanks in advance. |
|
@cormacpayne I see, this is indeed difficult to create scenario tests, so manual testing can ensure that the process meets expectations. So I'll merge this PR first |
|
[Release] Update index.json for extension [ containerapp ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=67193&view=results |
Recently, the
workflowNameproperty was removed from the/subscriptions/resourceGroups/providers/Microsoft.App/containerApps/sourcecontrols/currentAPI, which represented the name of the YAML workflow file created for the user viacontainerapp up --source(or through the Continuous Deployment blade in the Azure Portal), which allowed users to build and deploy their application using GitHub Actions.As a result of this property being removed, certain calls in the
upflow when--sourcewas provided (such as here and here) are throwing exceptions when attempting to access the property in the API response.With this PR, a new function is introduced,
get_workflow_name, that will user the GitHub API (specifically, this call) to fetch the files in given repository's branch, and see if any within the.github/workflowsfolder match the expected YAML file name ({containerAppName}-AutoDeployTrigger-{guid}.yml).This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az containerapp upGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
- [ ] My extension description/summary conforms to the Extension Summary Guidelines.About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.