Skip to content

containerapp --registry-server support custom port #6406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhoxing-ms merged 4 commits into from
Jun 15, 2023
Merged

containerapp --registry-server support custom port #6406

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
56c297d
support registry witl port
Greedygre Jun 14, 2023
0ea3973
Merge branch 'main' into xinyu/fix_for_register_with_port
Greedygre Jun 14, 2023
1de21d0
update history
Greedygre Jun 14, 2023
84a73e6
Merge branch 'main' into xinyu/fix_for_register_with_port
Greedygre Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/containerapp/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ Upcoming
++++++
* 'az containerapp job execution show/list': improve table output format
* 'az containerapp create/update': --yaml support properties for api-version 2023-04-01-preview (e.g. subPath, mountOptions)
* 'az containerapp create': --registry-server support registry with custom port

0.3.33
++++++
Expand Down
1 change: 1 addition & 0 deletions src/containerapp/azext_containerapp/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,6 +636,7 @@ def store_as_secret_and_return_secret_ref(secrets_list, registry_user, registry_
return registry_pass
else:
# If user passed in registry password
registry_server = registry_server.replace(':', '-')
if urlparse(registry_server).hostname is not None:
registry_secret_name = "{server}-{user}".format(server=urlparse(registry_server).hostname.replace('.', ''), user=registry_user.lower())
else:
Expand Down
Loading