Skip to content

Fix container app create not waiting for ready environment #6399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhoxing-ms merged 6 commits into from
Jun 25, 2023
Merged

Fix container app create not waiting for ready environment #6399

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0639c2d
fix create app not waiting and update tests
Jun 13, 2023
890976d
fix whitespace
Jun 13, 2023
59b3609
change safe get
Jun 15, 2023
7d6e089
fix default return
Jun 21, 2023
cf2c733
Merge remote-tracking branch 'origin2/main' into pbouchon/createAppMs…
Jun 21, 2023
92f302c
update changelog
Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/containerapp/azext_containerapp/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,11 @@ def create_containerapp(cmd,
if not managed_env_info:
raise ValidationError("The environment '{}' does not exist. Specify a valid environment".format(managed_env))

while not no_wait and "properties" in managed_env_info and managed_env_info["properties"]["provisioningState"].lower() in ["inprogress", "updating"]:
Comment thread
p-bouchon marked this conversation as resolved.
Outdated
logger.info("Waiting for environment provisioning to finish before creating container app")
time.sleep(10)
Comment thread
p-bouchon marked this conversation as resolved.
Outdated
managed_env_info = ManagedEnvironmentClient.show(cmd=cmd, resource_group_name=managed_env_rg, name=managed_env_name)

location = managed_env_info["location"]
_ensure_location_allowed(cmd, location, CONTAINER_APPS_RP, "containerApps")

Expand Down
Loading