Skip to content

Conversation

@Greedygre
Copy link
Contributor

@Greedygre Greedygre commented Jun 13, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az containerapp create/list/show/delete

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Hi @Greedygre,
If you want to release the new extension version.
Please write the description of changes into HISTORY.rst and update setup.py.

@ghost ghost requested a review from yonzhan June 13, 2023 03:48
@ghost ghost added the Auto-Assign Auto assign by bot label Jun 13, 2023
@ghost ghost requested a review from wangzelin007 June 13, 2023 03:48
@yonzhan
Copy link
Collaborator

yonzhan commented Jun 13, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@ghost ghost requested a review from yanzhudd June 13, 2023 03:48
@ghost ghost assigned zhoxing-ms Jun 13, 2023
@ghost ghost added the ContainerApp label Jun 13, 2023
@ghost ghost requested review from jsntcy and zhoxing-ms June 13, 2023 03:48
@Greedygre
Copy link
Contributor Author

Greedygre commented Jun 14, 2023

@zhoxing-ms
Copy link
Contributor

======================================================================
FAIL: test_checksums (main.TestIndex)

Traceback (most recent call last):
File "/mnt/vss/_work/1/s/./scripts/ci/test_index.py", line 138, in test_checksums
self.assertEqual(computed_hash, item['sha256Digest'],
AssertionError: '1d5d6d3ff7c18a7ce6ccdc5ac3dd4fc38b7b028fa9cf2e03ab58a05e6b733081' != 4c9a4ce36b23f6c6fc4bd1e3250c25cacef4f4db215309164bf82724d5f71218'
......
: Computed 1d5d6d3ff7c18a7ce6ccdc5ac3dd4fc38b7b028fa9cf2e03ab58a05e6b733081 but found 4c9a4ce36b23f6c6fc4bd1e3250c25cacef4f4db215309164bf82724d5f71218 in index for arcdata-1.5.1-py2.py3-none-any.whl

This issue should be introduced by PR #6353. @kairu-ms Could you help take a look at this issue?

@wangzelin007
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Greedygre Greedygre force-pushed the xinyu/containerapp_create_refactor branch from 71e4826 to d9f83d8 Compare June 19, 2023 07:13
@Juliehzl
Copy link
Contributor

rerun all tests for container app create

@Greedygre Greedygre force-pushed the xinyu/containerapp_create_refactor branch from 1c27de4 to 3b8abab Compare June 26, 2023 08:45
@Greedygre Greedygre force-pushed the xinyu/containerapp_create_refactor branch from 3b8abab to 5d5caca Compare June 26, 2023 08:48
@Greedygre Greedygre force-pushed the xinyu/containerapp_create_refactor branch from 5d5caca to 1a6467a Compare June 26, 2023 08:53
@Greedygre
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 6397 in repo Azure/azure-cli-extensions

@Greedygre
Copy link
Contributor Author

Greedygre commented Jun 28, 2023

Hi @zhoxing-ms
Could you please help to review and merge this PR?
Since we have other code that depends on this, I would appreciate any help.

@yanzhudd yanzhudd merged commit 8f07729 into Azure:main Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants