Skip to content

[Vm-repair] VM-repair removing unnecessary check #6326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhoxing-ms merged 3 commits into from
May 26, 2023
Merged

[Vm-repair] VM-repair removing unnecessary check #6326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95603e1
Update repair_utils.py
haagha May 25, 2023
0e79e0f
Update version in 0.5.3
haagha May 25, 2023
0b6441e
Update HISTORY.rst
haagha May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/vm-repair/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@

Release History
===============

0.5.3
++++++
Removing check for EncryptionSettingsCollection.enabled is string 'false'.

0.5.2
++++++
Fix bug in _fetch_encryption_settings, add check for EncryptionSettingsCollection.enabled is false.
Expand Down
2 changes: 0 additions & 2 deletions src/vm-repair/azext_vm_repair/repair_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,8 +352,6 @@ def _fetch_encryption_settings(source_vm):
return Encryption.NONE, key_vault, kekurl, secreturl
if not enabled:
return Encryption.NONE, key_vault, kekurl, secreturl
if enabled.tolower() == 'false':
return Encryption.NONE, key_vault, kekurl, secreturl
if kekurl == []:
key_vault, secreturl = key_vault[0], secreturl[0]
return Encryption.SINGLE_WITHOUT_KEK, key_vault, kekurl, secreturl
Expand Down
2 changes: 1 addition & 1 deletion src/vm-repair/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from codecs import open
from setuptools import setup, find_packages

VERSION = "0.5.2"
VERSION = "0.5.3"

CLASSIFIERS = [
'Development Status :: 4 - Beta',
Expand Down