Skip to content

Conversation

@smzeng
Copy link
Member

@smzeng smzeng commented May 23, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

We used to return a payload of each individual secret mounted when mounting all secrets. However, we recently changed the behavior to return no secret if all secrets are mounted as secrets can change in the future if user adds/removes secrets.

fixing CLI test to reflect this change.

Related command

az containerapp create --secret-volume-mount

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Hi @smzeng,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@azure-client-tools-bot-prd
Copy link

Hi @smzeng,
If you want to release the new extension version.
Please write the description of changes into HISTORY.rst and update setup.py.

@yonzhan
Copy link
Collaborator

yonzhan commented May 23, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@smzeng
Copy link
Member Author

smzeng commented May 23, 2023

@zhoxing-ms I was wondering if I could have some help figuring out why the Verify Docs step is failing? The error message isn't really clear to me.

`
ERROR: test_ref_doc_confcom (main.IndexRefDocs)

Traceback (most recent call last):
File "/mnt/vss/_work/1/s/./scripts/ci/index_ref_doc.py", line 65, in test
raise e
File "/mnt/vss/_work/1/s/./scripts/ci/index_ref_doc.py", line 62, in test
check_call(script_args)
File "/opt/hostedtoolcache/Python/3.10.11/x64/lib/python3.10/subprocess.py", line 369, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/opt/hostedtoolcache/Python/3.10.11/x64/bin/python', '/mnt/vss/_work/1/s/scripts/refdoc/generate.py', '--extension-file', '/tmp/tmp2bweov7a/confcom-0.2.14-py3-none-any.whl', '--output-dir', '/tmp/tmpxfnfucva/confcom']' returned non-zero exit status 1.


`

@zhoxing-ms
Copy link
Contributor

@smzeng Known issue, we already have a PR to fix it #6317

@zhoxing-ms zhoxing-ms merged commit e6fe774 into Azure:main May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants