Skip to content

Conversation

@anandanthony
Copy link
Contributor

PR to fix update command for Container App Job resources.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Hi @anandanthony,
If you want to release the new extension version.
Please write the description of changes into HISTORY.rst and update setup.py.

@azure-client-tools-bot-prd
Copy link

Hi @anandanthony,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@ghost ghost requested a review from yonzhan May 22, 2023 18:18
@ghost ghost added the Auto-Assign Auto assign by bot label May 22, 2023
@ghost ghost requested a review from wangzelin007 May 22, 2023 18:18
@yonzhan
Copy link
Collaborator

yonzhan commented May 22, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@ghost ghost requested a review from yanzhudd May 22, 2023 18:18
@ghost ghost assigned zhoxing-ms May 22, 2023
@ghost ghost added the ContainerApp label May 22, 2023
@ghost ghost requested review from jsntcy and zhoxing-ms May 22, 2023 18:18
@zhoxing-ms
Copy link
Contributor

Please write the description of PR into the HISTORY.rst, and if you want to release a new extension version for this PR, please also upgrade the version defined in the setup.py

0.3.31
++++++
* Fix issue when using 'az containerapp up' to create a container app from a local source with a Dockerfile
* Fix issue for 'az containerapp job update' when updating a job with trigger configurations
Copy link
Contributor

@zhoxing-ms zhoxing-ms May 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot add new content to the already released extension version, please add the description in the updated extension version.

@zhoxing-ms zhoxing-ms merged commit 84d8f85 into Azure:main May 25, 2023
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ containerapp ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=58105&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants