Skip to content

Conversation

@FumingZhang
Copy link
Member

@FumingZhang FumingZhang commented Apr 13, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

  • Fix the breaking change caused by default API version bump of the auth SDK, PR #25452.
  • Update pod identity related test cases and enable these cases by default in the cli runner.
  • Remove some unused role assignment related code (previously used for attach/detach acr).

Related command

az aks pod-identity

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Hi @FumingZhang,
If you want to release the new extension version.
Please write the description of changes into HISTORY.rst and update setup.py.

@ghost ghost requested a review from zhoxing-ms April 13, 2023 08:15
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 13, 2023

AKS

@ghost ghost requested a review from yanzhudd April 13, 2023 08:15
@ghost ghost assigned zhoxing-ms Apr 13, 2023
@ghost ghost added the Auto-Assign Auto assign by bot label Apr 13, 2023
@ghost ghost requested a review from yonzhan April 13, 2023 08:15
@ghost ghost added the AKS label Apr 13, 2023
@FumingZhang
Copy link
Member Author

Queued a live test pipeline to validate the change, test passed!

@FumingZhang FumingZhang marked this pull request as ready for review April 13, 2023 09:50
@zhoxing-ms zhoxing-ms merged commit 8272cd5 into Azure:main Apr 14, 2023
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=47908&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants