Skip to content

{Service Connector} Refactor for Azure CLI forward compatibility #5898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kairu-ms merged 2 commits into from
Feb 20, 2023
Merged

{Service Connector} Refactor for Azure CLI forward compatibility #5898

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2970861
update
xfz11 Feb 20, 2023
ea970a3
fix
xfz11 Feb 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/serviceconnector-passwordless/azext_serviceconnector_passwordless/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ def connection_create_ext(cmd, client, # pylint: disable=too-many-locals,too-ma
spring=None, app=None, deployment='default', # Resource.SpringCloud
# Resource.*Postgres, Resource.*Sql*
server=None, database=None,
**kwargs,
):
from azure.cli.command_modules.serviceconnector.custom import connection_create_func
from ._credential_free import enable_mi_for_db_linker
Expand All @@ -41,7 +42,8 @@ def connection_create_ext(cmd, client, # pylint: disable=too-many-locals,too-ma
site,
spring, app, deployment,
server, database,
enable_mi_for_db_linker=enable_mi_for_db_linker)
enable_mi_for_db_linker=enable_mi_for_db_linker,
**kwargs)


def local_connection_create_ext(cmd, client, # pylint: disable=too-many-locals,too-many-statements
Expand All @@ -56,6 +58,7 @@ def local_connection_create_ext(cmd, client, # pylint: disable=too-many-locals,
no_wait=False,
# Resource.*Postgres, Resource.*Sql*
server=None, database=None,
**kwargs
):
from azure.cli.command_modules.serviceconnector.custom import local_connection_create_func
from ._credential_free import enable_mi_for_db_linker
Expand All @@ -71,4 +74,5 @@ def local_connection_create_ext(cmd, client, # pylint: disable=too-many-locals,
no_wait,
# Resource.*Postgres, Resource.*Sql*
server, database,
enable_mi_for_db_linker=enable_mi_for_db_linker)
enable_mi_for_db_linker=enable_mi_for_db_linker,
**kwargs)