Skip to content

Conversation

@ZeroMagic
Copy link
Contributor

update AKV secrets provider help description


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested review from yanzhudd and zhoxing-ms February 17, 2023 06:38
@ghost ghost assigned zhoxing-ms Feb 17, 2023
@ghost ghost added this to the Feb 2023 (2023-03-07) milestone Feb 17, 2023
@ghost ghost added the Auto-Assign Auto assign by bot label Feb 17, 2023
@ghost ghost requested a review from yonzhan February 17, 2023 06:38
@ghost ghost added the AKS label Feb 17, 2023
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 17, 2023

AKS

@FumingZhang
Copy link
Member

CI failed due to one change in azure-cli. Fixed in PR #5890. Please rebase from main, once the fix is merged.

@ZeroMagic
Copy link
Contributor Author

CI failed due to one change in azure-cli. Fixed in PR #5890. Please rebase from main, once the fix is merged.

Rebased.

@zhoxing-ms zhoxing-ms merged commit 72b9b32 into Azure:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants