Skip to content

Conversation

@FumingZhang
Copy link
Member

@FumingZhang FumingZhang commented Feb 14, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

{AKS} Fix test case test_aks_create_and_update_with_node_restriction. The default version cannot meet the testing requirements (>1.22.0, <1.24.0). Select the appropriate k8s version for testing, if there is no suitable version, skip the test.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested review from yanzhudd and zhoxing-ms February 14, 2023 06:30
@ghost ghost assigned zhoxing-ms Feb 14, 2023
@ghost ghost added this to the Feb 2023 (2023-03-07) milestone Feb 14, 2023
@ghost ghost added the Auto-Assign Auto assign by bot label Feb 14, 2023
@ghost ghost requested a review from yonzhan February 14, 2023 06:31
@ghost ghost added the AKS label Feb 14, 2023
@FumingZhang FumingZhang marked this pull request as ready for review February 14, 2023 07:07
@yonzhan
Copy link
Collaborator

yonzhan commented Feb 14, 2023

AKS

@zhoxing-ms zhoxing-ms merged commit 2a4fceb into Azure:main Feb 15, 2023
@FumingZhang FumingZhang deleted the fuming/fix-node-restriction-test-0214 branch February 17, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants