Skip to content

Conversation

@MoChilia
Copy link
Member

@MoChilia MoChilia commented Feb 2, 2023

Description

Since new features for az storage blob list are added to main CLI directly without a change in extension, its code in storage-preview & storage-blob-preview is outdated now. In order to prevent the extension code overwriting what’s in main CLI, the related code should be removed from extension.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@MoChilia MoChilia requested a review from evelyn-ys February 2, 2023 02:31
@MoChilia MoChilia requested a review from calvinhzy as a code owner February 2, 2023 02:31
@ghost ghost added the Auto-Assign Auto assign by bot label Feb 2, 2023
@ghost ghost requested a review from yonzhan February 2, 2023 02:31
@ghost ghost added this to the Feb 2023 (2023-03-07) milestone Feb 2, 2023
@ghost ghost added the Storage label Feb 2, 2023
@MoChilia MoChilia changed the title [Storage] az storage blob list: Remove [Storage] az storage blob list: Remove Feb 2, 2023
@evelyn-ys evelyn-ys changed the title [Storage] az storage blob list: Remove [Storage] az storage blob list: Remove from extension since it has been supported in CLI Feb 2, 2023
@yonzhan
Copy link
Collaborator

yonzhan commented Feb 2, 2023

Storage

@MoChilia MoChilia merged commit 98b9415 into Azure:main Feb 2, 2023
@MoChilia MoChilia deleted the shiyingchen/remove_blob_list branch February 2, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Storage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants