Migrate dataprotection backup-vault to AAZ-dev-tools and add support for immutable vaults and soft delete
#5813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 10, 2023 11:00
ghost
requested a review
from 
ghost
added
the
Collaborator
|
dataprotection |
Contributor
Author
|
Could we assign this the Jan 2023 milestone? IIUC we need to complete this PR by February 7th for that. |
added 3 commits
February 8, 2023 13:09
In order to fix failing DPP tests, I had to enable soft-delete setting modification from the CLI extension.
zubairabid
changed the title
dataprotection backup-vault to AAZ-dev-tools and add support for immutable vaultsdataprotection backup-vault to AAZ-dev-tools and add support for immutable vaults and soft delete
zhoxing-ms
reviewed
Feb 9, 2023
src/dataprotection/azext_dataprotection/aaz/latest/dataprotection/backup_vault/_create.py
Outdated
Show resolved
Hide resolved
zhoxing-ms
reviewed
Feb 9, 2023
src/dataprotection/azext_dataprotection/aaz/latest/dataprotection/backup_vault/_create.py
Outdated
Show resolved
Hide resolved
evelyn-ys
requested changes
Feb 13, 2023
Member
evelyn-ys
left a comment
evelyn-ys
left a comment
There was a problem hiding this comment.
If you want to release a new version of dataprotection extension, please update setup.py and history.rst
zubairabid
requested review from
evelyn-ys
and removed request for
calvinhzy and
yonzhan
evelyn-ys
approved these changes
Feb 13, 2023
Member
|
@wangzelin007 We need to fix API version mismatch issue when checking min core version😂 |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
@evelyn-ys Is there anything that I need to do to resolve this? |
zhoxing-ms
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az dataprotection backup-vaultdataprotection backup-vaultcommand was migrated to AAZ-dev-tools from autorest.immutability-stateflag was added.soft-delete-stateretention-duration-in-days/soft-delete-retentionGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:- [ ] My extension description/summary conforms to the Extension Summary Guidelines.About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.