Skip to content

Conversation

@tdaroly
Copy link
Contributor

@tdaroly tdaroly commented Jan 30, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 30, 2023

containerapp

@zhoxing-ms
Copy link
Contributor

Do you need to release a new extension version for this PR? If so, please update the history notes in HISTORY.rst and the version defined in the setup.py

@StrawnSC
Copy link
Contributor

Hey @zhoxing-ms, I noticed that this PR was opened after we changed the CODEOWNERS for the containerapp extension, but I'm not seeing the new CODEOWNERS requested as reviewers. Do you know what's up with that? I thought CODEOWNERS would automatically be requested as reviewers

# HISTORY.rst entry.

VERSION = '0.3.20'
VERSION = '0.3.22'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that version 0.3.21 has not been released yet? Can this PR be released together in version 0.3.21?

Comment on lines 5 to 7
0.3.22
++++++
* Fix the empty IP Restrictions object caused running `az containerapp update` command on Windows with a pre existing .yaml file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may consider placing this history note in version 0.3.21

@zhoxing-ms zhoxing-ms merged commit 884929a into Azure:main Feb 1, 2023
@azclibot
Copy link
Collaborator

azclibot commented Feb 1, 2023

[Release] Update index.json for extension [ containerapp ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=29941&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants