-
Notifications
You must be signed in to change notification settings - Fork 1.5k
update models to include ip restrictions feat #5812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update models to include ip restrictions feat #5812
Conversation
|
containerapp |
|
Do you need to release a new extension version for this PR? If so, please update the history notes in |
|
Hey @zhoxing-ms, I noticed that this PR was opened after we changed the CODEOWNERS for the containerapp extension, but I'm not seeing the new CODEOWNERS requested as reviewers. Do you know what's up with that? I thought CODEOWNERS would automatically be requested as reviewers |
src/containerapp/setup.py
Outdated
| # HISTORY.rst entry. | ||
|
|
||
| VERSION = '0.3.20' | ||
| VERSION = '0.3.22' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that version 0.3.21 has not been released yet? Can this PR be released together in version 0.3.21?
src/containerapp/HISTORY.rst
Outdated
| 0.3.22 | ||
| ++++++ | ||
| * Fix the empty IP Restrictions object caused running `az containerapp update` command on Windows with a pre existing .yaml file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may consider placing this history note in version 0.3.21
|
[Release] Update index.json for extension [ containerapp ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=29941&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.